Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-26 Thread Seán Coffey
Valeriy, those changes look fine to me and I've verified that they run through testing fine also. webrev here for reference : http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v3/webrev/ Can I have a jdk7u reviewer for this change ? Regards, Sean. On 26/01/15 10:26, Valery Kopylov

RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-26 Thread Valery Kopylov (Akvelon)
Sean, Thank you for your changes! However, instead of checking for WSAEINVAL we propose to check for Windows version. There are two potential issues our approach helps to avoid: 1. On Win8 the only error code WSAEOPNOTSUPP means that loopback can't be set. All other errors should throw