Re: RFR: JDK-8046901 - Check jdk/src/solaris/native/sun/nio for Parfait flagged uninitialized memory

2015-02-18 Thread Roger Riggs
Hi, Looks fine to me also. Unfortunately, marking false positives in the tool creates a required synchronization between the tool configuration and the JDK, if that gets lost or out of sync the warnings might re-appear. In theory, it might be possible to inform the tool of what happens to the

Re: RFR: JDK-8046901 - Check jdk/src/solaris/native/sun/nio for Parfait flagged uninitialized memory

2015-02-18 Thread Alan Bateman
On 18/02/2015 15:45, Mark Sheppard wrote: Hi Alan, that's correct it's not an issue (false positive) as port is an out parameter, but the prescription was to initialize any flagged variables. I don't object to the change of course but I would have thought that it should be possible to flag

Re: RFR: JDK-8046901 - Check jdk/src/solaris/native/sun/nio for Parfait flagged uninitialized memory

2015-02-18 Thread Mark Sheppard
Hi Alan, that's correct it's not an issue (false positive) as port is an out parameter, but the prescription was to initialize any flagged variables. regards Mark On 18/02/2015 15:37, Alan Bateman wrote: On 18/02/2015 15:30, Mark Sheppard wrote: Hi please oblige and review the followin

RFR: JDK-8046901 - Check jdk/src/solaris/native/sun/nio for Parfait flagged uninitialized memory

2015-02-18 Thread Mark Sheppard
Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8046901/webrev/ which address the parfait issues in https://bugs.openjdk.java.net/browse/JDK-8046901 pertaining to uninitialized memory in src/java.base/unix/native/libnio/ch/DatagramChannelImpl.c src/java.

Re: RFR: JDK-8046901 - Check jdk/src/solaris/native/sun/nio for Parfait flagged uninitialized memory

2015-02-18 Thread Alan Bateman
On 18/02/2015 15:30, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8046901/webrev/ which address the parfait issues in https://bugs.openjdk.java.net/browse/JDK-8046901 pertaining to uninitialized memory in src/java.base/unix/nativ

Re: RFR: JDK-8046893 - JNI exception pending in jdk/src/solaris/native/java/net: ExtendedOptionsImpl.c, PlainDatagramSocketImpl.c

2015-02-18 Thread Chris Hegarty
Looks ok to me Mark. -Chris. On 18/02/15 13:19, Mark Sheppard wrote: Hi please review the following small change http://cr.openjdk.java.net/~msheppar/8046893/webrev/ which addresses the parfait issue in https://bugs.openjdk.java.net/browse/JDK-8046893 regards Mark

Re: RFR: JDK-8046893 - JNI exception pending in jdk/src/solaris/native/java/net: ExtendedOptionsImpl.c, PlainDatagramSocketImpl.c

2015-02-18 Thread Alan Bateman
On 18/02/2015 13:19, Mark Sheppard wrote: Hi please review the following small change http://cr.openjdk.java.net/~msheppar/8046893/webrev/ which addresses the parfait issue in https://bugs.openjdk.java.net/browse/JDK-8046893 This looks okay. -Alan

RFR: JDK-8046893 - JNI exception pending in jdk/src/solaris/native/java/net: ExtendedOptionsImpl.c, PlainDatagramSocketImpl.c

2015-02-18 Thread Mark Sheppard
Hi please review the following small change http://cr.openjdk.java.net/~msheppar/8046893/webrev/ which addresses the parfait issue in https://bugs.openjdk.java.net/browse/JDK-8046893 regards Mark