Re: RFR JDK-8087113: Websocket API and implementation

2016-03-31 Thread Jitendra Kotamraju
> > > > You see there'a thing. That's why I didn't do it immediately. For example > let's > consider a "Sec-WebSocket-Extensions" (a very good illustrative example.) > RFC 6455 states it very clearly [1]: > > The |Sec-WebSocket-Extensions| header field MAY appear multiple times > in an

Re: RFR JDK-8087113: Websocket API and implementation

2016-03-31 Thread Pavel Rappo
Hi Chris, > On 31 Mar 2016, at 17:35, Chris Hegarty wrote: > > I’ve looked at the API a number of times, and overall I’m happy with it > ( modulo the known open issues ). Some initial comments. Thanks a lot for looking into this! > Generally, I prefer javadoc style

Re: RFR JDK-8087113: Websocket API and implementation

2016-03-31 Thread Chris Hegarty
On 25 Mar 2016, at 16:21, Pavel Rappo wrote: > Hi, > > Could you please review my change for JDK-8087113 > > http://cr.openjdk.java.net/~prappo/8087113/webrev.03/ I’ve looked at the API a number of times, and overall I’m happy with it ( modulo the known open issues

Re: RFR JDK-8087113: Websocket API and implementation

2016-03-31 Thread Seán Coffey
On 29/03/2016 20:16, Andrej Golovnin wrote: 177 throw new IllegalArgumentException(String.valueOf(n)); >> >>Could you please provide a better message for exception here? > >What would the purpose be? It's an internal implementation detail. If this >exception is

Re: RFR JDK-8087113: Websocket API and implementation

2016-03-31 Thread Pavel Rappo
> On 29 Mar 2016, at 20:16, Andrej Golovnin wrote: > > JEP-280 does not apply in this case. But when you rewrite this code to > use the plain String concatenation, then JEP-280 would apply: > > 211 static String toString(Buffer b) { > 212 return