Re: RFR: 8071125: Improve exception messages in URLPermission

2016-04-20 Thread Chris Hegarty
On 20 Apr 2016, at 18:19, Seán Coffey wrote: > webrev updated in place with suggestion from Pavel (off thread) to place > quotes around the problem values. Quotes or square brackets. My preference is for the latter, but go with whichever you like. Consider this

Re: RFR: 8071125: Improve exception messages in URLPermission

2016-04-20 Thread Seán Coffey
webrev updated in place with suggestion from Pavel (off thread) to place quotes around the problem values. Regards, Sean. On 20/04/16 14:33, Seán Coffey wrote: Looking for a review for these simple changes. URLPermissions is a class introduced for JDK 8. Exception messaging can be improved to

RFR: 8071125: Improve exception messages in URLPermission

2016-04-20 Thread Seán Coffey
Looking for a review for these simple changes. URLPermissions is a class introduced for JDK 8. Exception messaging can be improved to capture context. https://bugs.openjdk.java.net/browse/JDK-8071125 http://cr.openjdk.java.net/~coffeys/webrev.8071125/webrev/ -- Regards, Sean.

Re: RFR 8154543, NetworkInterfaceStreamTest.java fails intermittently after JDK-8146758

2016-04-20 Thread Felix Yang
Thanks, Chris :-) -Felix On 2016/4/20 15:26, Chris Hegarty wrote: This looks ok to me Felix. -Chris. On 20 Apr 2016, at 08:07, Felix Yang wrote: Hi there, I introduced a problem in fix for JDK-8146758. When calling allNetworkInterfaces(), it will concat sub

Re: RFR 8154543, NetworkInterfaceStreamTest.java fails intermittently after JDK-8146758

2016-04-20 Thread Chris Hegarty
This looks ok to me Felix. -Chris. On 20 Apr 2016, at 08:07, Felix Yang wrote: > Hi there, >I introduced a problem in fix for JDK-8146758. When calling > allNetworkInterfaces(), it will concat sub interfaces into the stream > incorrectly. Then the test fails on a

RFR 8154543, NetworkInterfaceStreamTest.java fails intermittently after JDK-8146758

2016-04-20 Thread Felix Yang
Hi there, I introduced a problem in fix for JDK-8146758. When calling allNetworkInterfaces(), it will concat sub interfaces into the stream incorrectly. Then the test fails on a Solaris host which has virtual(sub) interfaces. Bug: https://bugs.openjdk.java.net/browse/JDK-8154543 Webrev: