Re: RFR 8151788: NullPointerException from ntlm.Client.type3

Hi All, Please find the updated webrev(http://cr.openjdk.java.net/%7Evtewari/8151788/webrev0.1/index.html). I addressed the review comments. Thanks, Vyom On Tuesday 12 July 2016 08:25 PM, Weijun Wang wrote: On 7/12/2016 22:34, Pavel Rappo wrote: What's the difference between no security

RE: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

Chris, thanks for your comments. I'm kind of thinking the same - I actually also don't really like my result of merging the strings of code so much. I'll go on and prepare a smaller change set only addressing the real bugs. I also agree to switching the Linux implementation to getifaddrs at the

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

On 7/12/2016 22:34, Pavel Rappo wrote: What's the difference between no security buffer and an empty one (from the com.sun.security.ntlm.Client#type3's perspective)? I quickly browse through the NTLM protocol and yes they look like the same in each case. (Except for one which I am not sure,

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

What's the difference between no security buffer and an empty one (from the com.sun.security.ntlm.Client#type3's perspective)? > On 12 Jul 2016, at 15:25, Wang Weijun wrote: > > When there is no offset, there is no security buffer at all. When the length > is zero, the security buffer is an emp

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

The fix looks fine to me. The readSecurityBuffer() is correct. When there is no offset, there is no security buffer at all. When the length is zero, the security buffer is an empty byte array. Here I think the customer encountered a server-side error. The fix is for interop with this abnorma

Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(String path) handle "null" incorrectly

Svetlana, >> The source code changes look fine. On the test... > On 11 Jul 2016, at 14:20, Daniel Fuchs wrote: > > Hi Svetlana, > > Have you thought of using a CountDownLatch (or some other > synchronization mechanism like e.g. Se

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

Hi Vyom, I wonder if Max (the author of the original NTLM.java) has seen the fix? The reason I'm asking is that when I see this byte[] readSecurityBuffer(int offset) throws NTLMException { int pos = readInt(offset+4); * if (pos == 0) return null; try { return

Re: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

Christoph, > On 11 Jul 2016, at 14:36, Langer, Christoph wrote: > > Hi Chris (or anyone who is holding a stake in the NetworkInterface native > implementation), > > I’ve spent some time on cleaning up NetworkInterface.c and came up with a > bigger change:http://cr.openjdk.java.net/~clanger/w

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

gentile reminder. Vyom On Thursday 30 June 2016 02:16 PM, Vyom Tewari wrote: Hi All, Please review the below simple fix. Bug: JDK-8151788 NullPointerException from ntlm.Client.type3 Webrev : http://cr.openjdk.java.net/~vtewari/8151788/webrev0.0/index.html

Re: RFR 8144692: HttpServer API: use of non-existant method in example in package Javadoc

Hi Pavel, Thanks for review, i updated the webrev(http://cr.openjdk.java.net/~vtewari/8144692/webrev0.0/index.html ) in place. Thanks, Vyom On Tuesday 12 July 2016 06:10 PM, Pavel Rappo wrote: Hi Vyom, A minor comment.

Re: RFR 8144692: HttpServer API: use of non-existant method in example in package Javadoc

Hi Vyom, A minor comment. Do you think it would make sense to use space after new InetSocketAddress(8000), as in every other line in this javadoc where multiple arguments passed, the space is used. Just to be consistent in formatting. Thanks. > On 12 Jul 2016, at 12:36, Vyom Tewari w

RFR 8144692: HttpServer API: use of non-existant method in example in package Javadoc

Hi All, Please review below small doc fix. Bug: JDK-8144692 HttpServer API: use of non-existant method in example in package Javadoc Webrev : http://cr.openjdk.java.net/~vtewari/8144692/webrev0.0/index.html