RFR 8161291: Serialization Tests for URLPermission is failing

2016-07-21 Thread Vyom Tewari
Hi, Please review the below code change. Bug: JDK-8161291 Serialization Tests for URLPermission is failing Webrev : http://cr.openjdk.java.net/~vtewari/8161291/webrev0.0/index.html This change make sure that

Re: PING: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

2016-07-21 Thread Chris Hegarty
Hi Christoph, On 19/07/16 14:48, Langer, Christoph wrote: Hi all, can I please get a review for my change: http://cr.openjdk.java.net/~clanger/webrevs/8160174.3/ ? This really hard to review, since so many parts of the code are moving around, but we did put this off a few times already so

Re: RFR [9] 8078568 java/net/URLPermission/URLTest.java fails intermittently with BindException

2016-07-21 Thread Daniel Fuchs
On 21/07/16 15:20, Chris Hegarty wrote: The new version does not check that e is an instance of SecurityExcption. I'm also a bit surprised to see that the test expects the SecurityException to be wrapped. The SE is expected to be wrapped because of the use of getResponseCode(), as opposed to

Re: RFR [9] 8078568 java/net/URLPermission/URLTest.java fails intermittently with BindException

2016-07-21 Thread Chris Hegarty
On 21/07/16 14:37, Daniel Fuchs wrote: Hi, Looks good to me Chris. Thanks for the review Daniel. The only thing I noticed is this: -if (! (e instanceof SecurityException) && -!(e.getCause() instanceof SecurityException) || -

Re: RFR [9] 8078568 java/net/URLPermission/URLTest.java fails intermittently with BindException

2016-07-21 Thread Daniel Fuchs
Hi, Looks good to me Chris. The only thing I noticed is this: -if (! (e instanceof SecurityException) && -!(e.getCause() instanceof SecurityException) || -!exceptionExpected) -{ -System.out.println