Re: [9] RFR: 8164591: sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java failed with SSLHandshakeException

2016-09-07 Thread Artem Smotrakov
Sending to net-dev@openjdk.java.net as well. Artem On 09/07/2016 12:28 PM, Artem Smotrakov wrote: Hello, Please review the following patch for sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java The test has been observed to fail a couple of times, but it's still not clear why

Re: HTTP client API

2016-09-07 Thread Michael McMahon
Hi Wenbo, First, sorry for the delay in replying. We took your comments and prototyped how the major ones might be accommodated. In particular, we did the following: - moved "business logic" out of HttpRequest. The methods for sending requests now exist in HttpClient. Given that requests

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Vyom Tewari
Hi Chris, Sorry I was mostly focusing on our test failure first, i will check your suggestions. Thanks, Vyom On Wednesday 07 September 2016 08:44 PM, Langer, Christoph wrote: Hi Vyom, did you have a look at my suggestions regarding AIX and refactoring? I can't find none of it in the

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Langer, Christoph
Hi Vyom, did you have a look at my suggestions regarding AIX and refactoring? I can't find none of it in the new webrev nor did you comment on it. Best regards Christoph > -Original Message- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Vyom > Tewari > Sent:

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Vyom Tewari
Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.4/index.html ). there were some test failures in JPRT and Chris also pointed the same issue in modified code. Now with latest code

RFR: 6947916: JarURLConnection does not handle useCaches correctly

2016-09-07 Thread Rob McKenna
Hi folks, Looking for a review of this simple enough fix: http://cr.openjdk.java.net/~robm/6947916/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-6947916 In a nutshell, if multiple URLConnections are made to several files in a single jar, each will use the same backing JarFile object.

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Langer, Christoph
Hi Vyom, I ran an AIX build and I had to change the flag for the recv call in NET_NonBlockingRead from MSG_DONTWAIT to MSG_NONBLOCK to get it compiled. Other than that it's fine in principal. However, I had another look about where to place which code. I suggest to put the common NET_*

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Chris Hegarty
On 07/09/16 07:45, Vyom Tewari wrote: Hi Chris, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.3/index.html ). I did some code refactoring, JPRT is in progress. In terms of NET_Timeout**,

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Langer, Christoph
Hi Vyom, I'll do an AIX build with your patch and let you know later today. Best regards Christoph > -Original Message- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Vyom > Tewari > Sent: Mittwoch, 7. September 2016 08:46 > To: Chris Hegarty

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-07 Thread Vyom Tewari
Hi Chris, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.3/index.html ). I did some code refactoring, JPRT is in progress. I need help from some one to build and test latest changes on