Re: RFR: 6947916: JarURLConnection does not handle useCaches correctly

> On 7 Sep 2016, at 14:17, Rob McKenna wrote: > > Hi folks, > > Looking for a review of this simple enough fix: > > http://cr.openjdk.java.net/~robm/6947916/webrev.01/ > https://bugs.openjdk.java.net/browse/JDK-6947916 I think that the source changes are good, but the

Re: HTTP client API

Hi Michael What's the rationale for not turning all public classes into interfaces, since none of them contain any actual implementation code? On another note, I fail to see the point of HttpClient.Builder::priority: as far as I understand, HTTP/2 priority only comes into play when multiple

Re: RFR (XS): JDK-8165711:java/net/SetFactoryPermission/SetFactoryPermission.java needs to run in ovm mode

Reviewed. -Chris. > On 8 Sep 2016, at 16:08, Sean Coffey wrote: > > Looking for review for this simple edit. Testcase should run in ovm mode. > > https://bugs.openjdk.java.net/browse/JDK-8165711 > > patch : > > diff --git

RFR (XS): JDK-8165711:java/net/SetFactoryPermission/SetFactoryPermission.java needs to run in ovm mode

Looking for review for this simple edit. Testcase should run in ovm mode. https://bugs.openjdk.java.net/browse/JDK-8165711 patch : diff --git a/test/java/net/SetFactoryPermission/SetFactoryPermission.java b/test/java/net/SetFactoryPermission/SetFactoryPermission.java ---

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

On Thursday 08 September 2016 02:50 PM, Langer, Christoph wrote: Hi Vyom, this looks good. Is there any particular reason why NET_ReadWithTimeout should remain in SocketInputStream.c and not also move to net_util_md.c? That way you could also have a "static long getCurrentTime()" inside

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

Hi Vyom, this looks good. Is there any particular reason why NET_ReadWithTimeout should remain in SocketInputStream.c and not also move to net_util_md.c? That way you could also have a "static long getCurrentTime()" inside net_util_md.c, instead of an exported NET_GetCurrentTime(). And no

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

sending this mail again as my laptop clock got screwed. Vyom On Thursday 08 September 2016 08:49 AM, Vyom Tewari wrote: Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.5/index.html

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.5/index.html ). I fixed the AIX flag issue and move some come common code to "net_util_md.c" file. Thanks, Vyom On 9/8/2016 12:32

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

Hi Vyom, ok, thanks. I have one addition to my proposal: I don't think there's a need for a global NET_GetCurrentTime function. This one should probably be a static function inside net_util_md.c (static long getCurrentTime()). Best Christoph > -Original Message- > From: Vyom Tewari