Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-13 Thread Vyom Tewari
pushed. http://hg.openjdk.java.net/jdk9/dev/jdk/rev/af17b6bc08dd Vyom On Tuesday 13 September 2016 02:17 PM, Chris Hegarty wrote: Vyom, On 13 Sep 2016, at 04:00, Vyom Tewari wrote: any comment on latest webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.5/index.html) ? I am happ

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-13 Thread Langer, Christoph
... and one additional minor remark from my side: Please also check if the #include can be left out from src/java.base/unix/native/libnet/SocketInputStream.c - I don't think it's necessary now as the new "NET_ReadWithTimeout" function does not directly access time APIs. Other than that I'm fin

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-13 Thread Chris Hegarty
Vyom, > On 13 Sep 2016, at 04:00, Vyom Tewari wrote: > > any comment on latest > webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.5/index.html) ? I am happy with the way this change turned out. Reviewed. Trivially, before you push, just add a space to the four OS specific versions