RE: RFR: 8170544: Fix code scan findings in libnet

Hi Chris, thanks for looking. > 1) NetworkInterface.c > > I’m not sure that the close is really necessary, since a JNI pending > exception can only be thrown is sock is less than 0. I think just > removing the ' && (*env)->ExceptionOccurred(env)’ from the original > if statement

RE: [8u-dev]: Request for Approval: 8075484: SocketInputStream.socketRead0 can hang even with soTimeout set

Thanks Buck. I added the label and pushed: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/c43400eba8a3 I also added #include to net_util_md.c which I forgot in my webrev. Best regards Christoph > -Original Message- > From: David Buck [mailto:david.b...@oracle.com] > Sent:

RE: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

Hi Chris, I have addressed your comments in a new webrev. Can you please have a look at this one? http://cr.openjdk.java.net/~clanger/webrevs/8170868.3/ I created src/java.base/share/native/libnet/proxy_util.c/h and these files contain now the common used native parts. And I rewrote the code

Re: [8u-dev]: Request for Approval: 8075484: SocketInputStream.socketRead0 can hang even with soTimeout set

approved for push to 8u-dev once appropriate noreg label has been added to the bug report [ noreg bug labels ] http://openjdk.java.net/guide/changePlanning.html#noreg Cheers, -Buck On 2017/01/11 22:28, Langer, Christoph wrote: Hi, please approve this downport. Thanks, Chris, for the

[8u-dev]: Request for Approval: 8075484: SocketInputStream.socketRead0 can hang even with soTimeout set

Hi, please approve this downport. Thanks, Chris, for the Review. Best regards Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Mittwoch, 11. Januar 2017 11:47 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net

Re: [8u-dev]: Request for Review and Approval: 8075484: SocketInputStream.socketRead0 can hang even with soTimeout set

Hi Christoph, > On 9 Jan 2017, at 05:56, Langer, Christoph wrote: > > Ping: Please review this backport to JDK8. > > From: Langer, Christoph > Sent: Donnerstag, 29. Dezember 2016 10:37 > To: net-dev@openjdk.java.net; jdk8u-...@openjdk.java.net > Subject: [8u-dev]: