Hello,
Please review HTML5 related changes to the above modules, please
note there are no changes to the verbiage.
Thanks
Kumar
Webrev: http://cr.openjdk.java.net/~ksrini/8179697/webrev.0/
JBS: https://bugs.openjdk.java.net/browse/JDK-8179697
Hi Pavel,
Looks good.
Some files didn't have their copyright years updated - maybe
you could fix that before pushing.
jdk/incubator/http/internal/websocket/OpeningHandshake.java
line 121: It might be worth mentioning that '13' is mandated by
[RFC 6455](https://tools.ietf.org/html/rfc6455)
best
Daniel, thanks a lot for looking into this! I've addressed most of your
suggestions:
http://cr.openjdk.java.net/~prappo/8179021/webrev.01/
> On 9 May 2017, at 15:49, Daniel Fuchs wrote:
>
> Hi Pavel,
>
> A few nits:
>
> jdk/incubator/http/WebSocket.java:
>
>
Yes, I think the only public API that uses a long timeout value is the
NIO Selector class
and this doesn't use NET_Timeout() in its implementation.
- Michael
On 10/05/2017, 09:53, Claes Redestad wrote:
Hi,
yes, when we do int -> jlong conversion before multiplication is fine,
but there are
Hi,
yes, when we do int -> jlong conversion before multiplication is fine,
but there are some methods, such as NET_Timeout that takes long timeout
that seemed in danger.
After offline discussion it seems these are always called with what's
essentially an int thus we should be safe, but as a
Hi Claes,
thanks for review, timeout is "int" so even if you set max(2147483647)
value that int data type can hold, there will not be any overflow. If
you try to set very large number like "0x7fff" to int data
type you will get compile time error(integer number too large: