Re: [10] RFR 8187044: HttpClient ConnectionPool may spawn several concurrent CacheCleaner and prevent early GC of HttpClient.

2017-09-01 Thread Daniel Fuchs
On 01/09/2017 17:08, Chris Hegarty wrote: On 31/08/17 16:07, Daniel Fuchs wrote: Hi, Please find below a small fix for: 8187044: HttpClient ConnectionPool may spawn several concurrent CacheCleaner and prevent early GC of HttpClient. https://bugs.openjdk.java.net/browse/JDK-8187044

Re: [10] RFR 8187044: HttpClient ConnectionPool may spawn several concurrent CacheCleaner and prevent early GC of HttpClient.

2017-09-01 Thread Chris Hegarty
On 31/08/17 16:07, Daniel Fuchs wrote: Hi, Please find below a small fix for: 8187044: HttpClient ConnectionPool may spawn several concurrent CacheCleaner and prevent early GC of HttpClient. https://bugs.openjdk.java.net/browse/JDK-8187044 webrev:

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-01 Thread Mark Sheppard
Hi   it's  worth noting that there is diagnostic output for each of the test scenarios, and that for a failure scenario the details of the network interface associated with the failure is displayed. a typical failure scenario for this test is where a host has multiple network interfaces

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-01 Thread Roger Riggs
Hi Felix, Looks ok; though could be simpler to just print all the addresses of all NIs. findIntefacesWithDupAddress could use streams more effectively (if its worth the time to rewrite). The inetAddresses() method on NetworkInterface produces a stream of InetAddress which could be

RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-01 Thread Felix Yang
Hi there,     please review a test patch for isolating a network configuration issue, which led to TestInterfaces failing from time to time. Bug:     https://bugs.openjdk.java.net/browse/JDK-8134989 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8134989/webrev.00/ Thanks, Felix