Re: RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

2018-03-25 Thread Alan Bateman
On 25/03/2018 19:13, Ivan Gerasimov wrote: : In the code above, newfd was obtained from a call to accept() a few lines before this check. So, the Java code has no way of being aware of this socket, and it will never be closed unless we do it right here, before returning -1. The

Re: RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

2018-03-25 Thread Ivan Gerasimov
Hi Chris! On 3/25/18 6:37 AM, Chris Hegarty wrote: On 23 Mar 2018, at 21:55, Chris Hegarty > wrote: For reference, here's the combined webrev: http://cr.openjdk.java.net/~igerasim/8198358/03/webrev/

Re: RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

2018-03-25 Thread Chris Hegarty
> On 23 Mar 2018, at 21:55, Chris Hegarty wrote: > >> For reference, here's the combined webrev: >> http://cr.openjdk.java.net/~igerasim/8198358/03/webrev/ >> > > I think this is good. And thanks for the