Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

Hi Vyom! A few random comments: 1) src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java Collections.emptySet() produces an immutable set, so it must not be possible to add elements to it. Is there a test that verifies that ExtendedSocketOption.options(short) works as

Re: JEP 321 surface-level comments

On Tue, May 8, 2018 at 12:35 PM Chris Povirk wrote: Commenting inline on just a couple of points. > >- I second the idea of making HttpHeaders a final class, as proposed >as part of JDK-8184274 >. While "final >

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.2/index.html). I incorporated most of the review comments. Chris as you suggested in below mail i did not added the note for upper-bound because values are also OS specific. Thanks, Vyom On Monday 23