Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

Hi Vyom! 1) src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java Thank you for fixing ExtendingSocketOption.options0(). It may be better to make the returned set unmodifiable, and then Collectors.toUnmodifiableSet could be used for convenience: return options.stream()

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

thanks all for review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.3/index.html). I address most of the  review comments. Vyom On Saturday 12 May 2018 12:01 AM, Chris Hegarty wrote: On 11 May 2018, at 01:04, Alan Bateman wrote:

Re: Behaviour of SocketChannelImpl.close() in Java11 (ea+12)

Hello, What about at least adding a change warning to Release Notes? We do have software which depends on the possibility to actually reset a connection instead of closing it cleanly (think FTP data connection proxy), luckily in our case it’s blocking so we would not be affected, but I can

Re: Behaviour of SocketChannelImpl.close() in Java11 (ea+12)

> On 11. May 2018, at 21:34, Alan Bateman wrote: > > (cc'ing nio-dev as as this is asking about SocketChannel). > > On 11/05/2018 19:10, Norman Maurer wrote: >> Hi all, >> >> I recently started to test Netty [1] with Java11 and found that we have two >> tests that

Re: Behaviour of SocketChannelImpl.close() in Java11 (ea+12)

(cc'ing nio-dev as as this is asking about SocketChannel). On 11/05/2018 19:10, Norman Maurer wrote: Hi all, I recently started to test Netty [1] with Java11 and found that we have two tests that are currently failing due some changes in Java 11 compared to earlier versions. I wanted to

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

On 11/05/2018 19:31, Chris Hegarty wrote: : P.S. A separate issue, but when reviewing this it reminded me that we should deprecate-for-removal jdk/net/Sockets.java. It’s functionality is already supported by a standard API. I think just the methods rather than the class. Lucy Yingqi is

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

On 11 May 2018, at 01:04, Alan Bateman wrote: > > On 10/05/2018 16:21, vyom tewari wrote: >> Hi, >> >> Please find the latest >> webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.2/index.html) >> ... > It would be better if the channel implementation didn't

Re: Behaviour of SocketChannelImpl.close() in Java11 (ea+12)

Sorry I just noticed this would better be asked on nio.dev. Will ask there. Bye Norman > On 11. May 2018, at 20:10, Norman Maurer wrote: > > Hi all, > > I recently started to test Netty [1] with Java11 and found that we have two > tests that are currently

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

On 10/05/2018 16:21, vyom tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.2/index.html). I incorporated most of the review comments. Chris as you suggested in below mail i did not added the note for upper-bound because values are also OS