Re: RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Thomas Stüfe
Thanks for clarifying! Thomas On Wed, Sep 26, 2018, 14:20 Baesken, Matthias wrote: > Hi Thomas, I think your understanding is correct : > > "#ifdef " > > or > > "#if defined()" > > Are ok while > > "#if " > > or > > "#elif " > > Lead to the compile error on gcc with current warnings. > > Best

RE: RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Baesken, Matthias
Hi Thomas, I think your understanding is correct : "#ifdef " or "#if defined()" Are ok while "#if " or "#elif " Lead to the compile error on gcc with current warnings. Best regards, Matthias > >> > > This looks okay to me although I could imagine this issue coming back again > > with o

Re: Public API to get the search list that is used on the system

2018-09-26 Thread Norman Maurer
BTW I am happy to open an enhancement request for this with more details . Just wanted to check in first here :) Just let me know if I should do or not. Bye Norman > On 26. Sep 2018, at 13:15, Norman Maurer wrote: > > Yeah preferable a method for both but JNDI works for the nameservers for n

Re: [CAUTION] RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread David Holmes
That all seems fine to me. Thanks for fixing. David On 26/09/2018 5:48 AM, Langer, Christoph wrote: Hi Matthias, looks good (and trivial). Ccing serviceability-dev because of change in libjdwp. Best regards Christoph *From:*nio-dev *On Behalf Of *Baesken, Matthias *Sent:* Mittwoch, 26

Re: Public API to get the search list that is used on the system

2018-09-26 Thread Norman Maurer
Yeah preferable a method for both but JNDI works for the nameservers for now. > Am 26.09.2018 um 13:06 schrieb Chris Hegarty : > > Hi Norman, > > A non-blocking DNS resolver, good use-case. > > Clearly the system configured name servers are of interest too ( I bring > it up since your specific

Re: Public API to get the search list that is used on the system

2018-09-26 Thread Chris Hegarty
Hi Norman, A non-blocking DNS resolver, good use-case. Clearly the system configured name servers are of interest too ( I bring it up since your specific request is about search domains )? Search domains are only part of the problem. I assume you can retrieve the name servers through the JDNI A

Re: Public API to get the search list that is used on the system

2018-09-26 Thread Norman Maurer
Yeah… In netty we an DNS resolver implementation that is completely non-blocking and for this we need it to correctly resolve in some cases. Blocking DNS resolution just doesn’t “cut it” when you use non-blocking IO and also need to resolve a lot of stuff during connect etc. Bye Norman > On

Re: Public API to get the search list that is used on the system

2018-09-26 Thread Chris Hegarty
Hi Norman, As you correctly found, there is a private implementation that is used by JNDI. As far as I am aware, there are no plans to provide a Java SE API for retrieving the default search domain list. Is there a particular use-case that you have in mind that requires this? -Chris. On 26/09/1

Re: RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Thomas Stüfe
On Wed, Sep 26, 2018 at 11:51 AM, Alan Bateman wrote: > > > On 26/09/2018 10:24, Baesken, Matthias wrote: >> >> >> Hello, please review this small build fix . >> >> After the recent changes to the gcc compile flags with 8211029, >> most of our Linux builds stopped working . >> >> Error :

Re: RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Chris Hegarty
On 26/09/18 10:24, Baesken, Matthias wrote: ...wse/JDK-8211146 http://cr.openjdk.java.net/~mbaesken/webrevs/8211146.0/ Looks good Matthias. -Chris.

Re: RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Aleksey Shipilev
On 09/26/2018 11:24 AM, Baesken, Matthias wrote: > http://cr.openjdk.java.net/~mbaesken/webrevs/8211146.0/ Oh, nice catch. This looks good to me. -Aleksey signature.asc Description: OpenPGP digital signature

Re: RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Alan Bateman
On 26/09/2018 10:24, Baesken, Matthias wrote: Hello, please review this small build fix . After the recent changes  to  the gcc compile flags   with  8211029    , most of our  Linux builds stopped working . Error : === Output from failing command(s) repeated here === * For target support

RE: [CAUTION] RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Langer, Christoph
Hi Matthias, looks good (and trivial). Ccing serviceability-dev because of change in libjdwp. Best regards Christoph From: nio-dev On Behalf Of Baesken, Matthias Sent: Mittwoch, 26. September 2018 11:25 To: 'build-...@openjdk.java.net' ; net-dev ; nio-...@openjdk.java.net Cc: Lindenmaier, Goet

RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef

2018-09-26 Thread Baesken, Matthias
Hello, please review this small build fix . After the recent changes to the gcc compile flags with 8211029, most of our Linux builds stopped working . Error : === Output from failing command(s) repeated here === * For target support_native_java.base_libnet_DatagramPacket.o: In file i

Public API to get the search list that is used on the system

2018-09-26 Thread Norman Maurer
Hi all, I wonder if there is any plan to provide a public domain to receive the “search list”. At the moment this is exposed via an internal API only: sun.net .dns.ResolverConfiguration.searchlist() I know I can use JNDI to get a list of dnsservers but I could not find anythin