Re: RFR: 8213942:URLStreamHandler initialization race

2018-11-20 Thread Chris Hegarty
Sean, > On 20 Nov 2018, at 17:55, Seán Coffey wrote: > > A race condition recently reported by the WLS team. Access to the handlers > Hashtable and the factory should be made while holding the streamHandlerLock > lock. > > WLS team also made efforts to create a reproducer. I've modified to jt

Re: RFR: 8213942:URLStreamHandler initialization race

2018-11-20 Thread Seán Coffey
On 20/11/2018 19:07, Alan Bateman wrote: On 20/11/2018 17:55, Seán Coffey wrote: A race condition recently reported by the WLS team. Access to the handlers Hashtable and the factory should be made while holding the streamHandlerLock lock. WLS team also made efforts to create a reproducer.

Re: RFR: 8213942:URLStreamHandler initialization race

2018-11-20 Thread Pavel Rappo
> On 20 Nov 2018, at 17:55, Seán Coffey wrote: > > Access to the handlers Hashtable and the factory should be made while holding > the streamHandlerLock lock I'm not sure about that. I wouldn't go with coarsening this lock's region. I would rather go with an additional check for handler being n

Re: RFR: 8213942:URLStreamHandler initialization race

2018-11-20 Thread Alan Bateman
On 20/11/2018 17:55, Seán Coffey wrote: A race condition recently reported by the WLS team. Access to the handlers Hashtable and the factory should be made while holding the streamHandlerLock lock. WLS team also made efforts to create a reproducer. I've modified to jtreg format and reduced it

RFR: 8213942:URLStreamHandler initialization race

2018-11-20 Thread Seán Coffey
A race condition recently reported by the WLS team. Access to the handlers Hashtable and the factory should be made while holding the streamHandlerLock lock. WLS team also made efforts to create a reproducer. I've modified to jtreg format and reduced it down further for unit testing. https:/