Re: [teststabilization] RFR: 8226825: Replace wildcard address with loopback or local host in tests - part 19

> On 27 Jun 2019, at 14:57, Julia Boes wrote: > > Hi, > > Thanks Brian and Chris for your comments! I incorporated the changes. > > Here's the updated webrev: > > http://cr.openjdk.java.net/~dfuchs/jboes/webrev_8226825/webrev.01/ Thanks for the updated webrev, Julia. You have my Review. -C

Re: [teststabilization] RFR: 8226825: Replace wildcard address with loopback or local host in tests - part 19

Hi, Thanks Brian and Chris for your comments! I incorporated the changes. Here's the updated webrev: http://cr.openjdk.java.net/~dfuchs/jboes/webrev_8226825/webrev.01/ Cheers, Julia On 26/06/2019 21:32, Chris Hegarty wrote: Julia, On 26 Jun 2019, at 18:33, Julia Boes wrote: Hi, Please

Re: RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

> On 27 Jun 2019, at 12:56, Daniel Fuchs wrote: > > On 27/06/2019 12:30, Chris Hegarty wrote: >> It is not an issue because there is an implicit reference ( from the >> nested class ). If we believe that the publisher is not strictly needed, >> then let's make the nested Subscription static, wh

Re: RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

On 27/06/2019 12:30, Chris Hegarty wrote: It is not an issue because there is an implicit reference ( from the nested class ). If we believe that the publisher is not strictly needed, then let's make the nested Subscription static, which will mean no ref, and is explicit. Concerns? Not from me

Re: RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

> On 27 Jun 2019, at 12:16, Daniel Fuchs wrote: > > Hi Micahel, Chris, > > On 27/06/2019 11:50, Chris Hegarty wrote: >>> http://cr.openjdk.java.net/~michaelm/8222968/webrev.1/index.html >> If I’m not mistaken, then after this change there will be no explicit >> reference to the PullPublisher.

Re: RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

Hi Chris, On 27/06/2019, 11:50, Chris Hegarty wrote: Michael, On 27 Jun 2019, at 11:08, Michael McMahon wrote: Could I get the following change reviewed please: The change is as suggested in the report and the test case is based on the one provided. http://cr.openjdk.java.net/~michaelm/82

Re: RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

Hi Micahel, Chris, On 27/06/2019 11:50, Chris Hegarty wrote: http://cr.openjdk.java.net/~michaelm/8222968/webrev.1/index.html If I’m not mistaken, then after this change there will be no explicit reference to the PullPublisher. There is an implicit reference from the nested Subscription. I thi

Re: RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

Michael, > On 27 Jun 2019, at 11:08, Michael McMahon > wrote: > > Could I get the following change reviewed please: > > The change is as suggested in the report and the test case > is based on the one provided. > > http://cr.openjdk.java.net/~michaelm/8222968/webrev.1/index.html If I’m not m

RFR: 8222968 ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests

Could I get the following change reviewed please: The change is as suggested in the report and the test case is based on the one provided. http://cr.openjdk.java.net/~michaelm/8222968/webrev.1/index.html Thanks, Michael.

Re: [teststabilization] RFR: 8226514: Replace wildcard address with loopback or local host in tests - part 17

Daniel, > On 26 Jun 2019, at 16:30, Daniel Fuchs wrote: > > Hi, > > Please find below a patch for: > > 8226514: Replace wildcard address with loopback or local host in > tests - part 17 > https://bugs.openjdk.java.net/browse/JDK-8226514 > > > webrev: > http://cr.openjdk.java.net/~dfu