Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8232513/webrev.01/
On 06/12/2019 17:05, Vyom Tewari26 wrote:
Your change looks OK but it will increase the worst case, running time
of test from (2500+1000)ms to (15000 + 1000)ms and this will definitely
decrease the probability of
Hi Julia,
Your change looks OK but it will increase the worst case, running time of test from (2500+1000)ms to (15000 + 1000)ms and this will definitely decrease the probability of intermittent failure but not 100% full proof.
Thanks,
Vyom
- Original message -From: Julia Boes
On 06/12/2019 15:34, Aleks Efimov wrote:
:
I've created webrev with your latest changes - it could be convenient
for other reviewers:
http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/00
I will happily sponsor this change once it gets necessary approvals
This could be split into two
Hi Patrick,
Thanks for explanation.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 , alan.bate...@oracle.comCc: daniel.fu...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8234148]: DatagramSocket.setOption/getOption/supportedOption should support
Hi Mark,
The test has a potential problem, that is the socket close can
cause the attempted send from server socket to client not to occur.
the sock.send() can result in the application data being copied into the
kernel and queued for sending. But the send may not take place
immediately.
Hi Vyom,
This check won't be run on Windows.
On Windows, the DualStackPlainDatagramSocketImpl implementation used for
DatagramSocket doesn’t support multicast, and at this time doesn’t
support multicast options either. So there is nothing to check on Windows.
We have plans to rework
On 06/12/2019 10:01, Patrick Concannon wrote:
Hi Alan,
Ah OK. I didn't spot that in your original email. Yeah that seems like
more concise way to put it.
I've made that change now, and updated the previous webrev.
http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.01/
Yes, I
Hi Alan,
Ah OK. I didn't spot that in your original email. Yeah that seems like
more concise way to put it.
I've made that change now, and updated the previous webrev.
http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.01/
Kind regards,
Patrick
On 05/12/2019 17:39, Alan
Hi Patrick,
Changes looks OK to me except, SupportedOptionsCheck tests
if (!Platform.isWindows())
55 assertTrue(options.containsAll(multicastOptions));
What this test will do on Windows ?.
Thanks,
Vyom
- Original message -From: Alan Bateman Sent by: "net-dev"
