Thanks for your comments.
Updated version of the patch available as
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.07/
The exception part for the setOption method was updated
+} else if (option == SO_INCOMING_NAPI_ID) {
+if (!incomingNapiIdOpt
Hi Mikael,
I took a look at i18n related files. It looks good overall.
One nit in java/nio/charset/Charset/DefaultCharsetTest.java: If the test
is only applicable to linux (@requires os.family == "linux" in jtreg tag
after the change), the condition isLinux() is no longer needed at line 73.
Hi Michael,
Looks good.
Maybe just a future cleanup to rename files, since the "...so..." is
refering to solaris.
src/java.base/unix/native/libjli/java_md_solinux.h
src/java.base/unix/native/libjli/java_md_solinux.h
Regards, Roger
On 5/4/20 4:49 AM, Alan Bateman wrote:
On 04/05/2020 06:12
There are several security-related files (name.contains("security")) and they
all look fine.
--Max
> On May 4, 2020, at 1:12 PM, Mikael Vidstedt
> wrote:
>
>
> Please review this change which implements part of JEP 381:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
> webrev:
>
On 04/05/2020 06:12, Mikael Vidstedt wrote:
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/corelibs/open/webrev/
JEP: https://bugs.openjdk.java.net/browse/JDK-
