Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-03-16 Thread Chris Hegarty
On Fri, 19 Feb 2021 14:53:36 GMT, Conor Cleary wrote: >> src/java.base/unix/native/libnet/Inet4AddressImpl.c line 375: >> >>> 373: icmp->icmp_type = ICMP_ECHO; >>> 374: icmp->icmp_code = 0; >>> 375: // same result as downcasting the little-endian pid, although >>> we are

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-16 Thread Andrew Haley
On Tue, 16 Mar 2021 15:01:02 GMT, Daniel Fuchs wrote: >> Jonathan Dowland has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Correct test invocation metadata >> >>-Xcheck:jni prior to the main class declaration; /othervm suffix no

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-16 Thread Daniel Fuchs
On Tue, 16 Mar 2021 14:12:46 GMT, Jonathan Dowland wrote: >> This is an adaptation of a patch originally written by Shafi Ahmad in >> a comment on the JBS page but never submitted or merged. >> >> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very >> quickly breaches the default

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-16 Thread Chris Hegarty
On Tue, 16 Mar 2021 14:12:46 GMT, Jonathan Dowland wrote: >> This is an adaptation of a patch originally written by Shafi Ahmad in >> a comment on the JBS page but never submitted or merged. >> >> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very >> quickly breaches the default

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v3]

2021-03-16 Thread Jonathan Dowland
On Mon, 15 Mar 2021 17:10:14 GMT, Chris Hegarty wrote: >> Jonathan Dowland has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains one commit: >> >> 8187450: JNI local refs exceeds capacity warning in >> NetworkInterface::getAll > > sr

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

2021-03-16 Thread Jonathan Dowland
On Mon, 15 Mar 2021 17:13:16 GMT, Chris Hegarty wrote: > No need to force-push - just push. The Skara workflow will generate > incremental diffs per-push and flatten all commits into one before final > integration into the JDK mainline. Thank you (yes this is my first time…) - PR

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-16 Thread Jonathan Dowland
> This is an adaptation of a patch originally written by Shafi Ahmad in > a comment on the JBS page but never submitted or merged. > > With -Xcheck:jni, the method java.net.NetworkInterface.getAll very > quickly breaches the default JNI local refs threshold (32). Exactly when > this happens depend

Integrated: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy

2021-03-16 Thread Andrey Turbanov
On Sun, 20 Dec 2020 17:05:21 GMT, Andrey Turbanov wrote: > 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy This pull request has now been integrated. Changeset: 68deb24b Author:Andrey Turbanov Committer: Julia Boes URL: https://git.