Integrated: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable

2021-04-08 Thread Julia Boes
On Tue, 16 Mar 2021 14:19:09 GMT, Julia Boes wrote: > The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable > by wrapping it in an unmodifiable view. This pull request has now been integrated. Changeset: 214d6e21 Author:Julia Boes URL: https://git.openjdk.java

Re: RFR: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable [v6]

2021-04-08 Thread Michael McMahon
On Wed, 7 Apr 2021 17:07:44 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> assign unmodHeaders instead of original headers > > Marked as reviewed by dfuchs (Reviewer). Latest changes LGTM. --

Re: Re: New candidate JEP: 408: Simple Web Server

2021-04-08 Thread Zheka Kozlov
Can we put at least new classes to some java.* package (SimpleFileServer, HttpHandlers, Request)? For example, java.net.httpserver. вт, 30 мар. 2021 г. в 20:14, Julia Boes : > Hi Krzysztof, > > Is there a plan to change the package name? > I always thought that com.sun.* package was for old inter

Re: RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Andrew Dinn
On 08/04/2021 10:11, Daniel Fuchs wrote: On Thu, 8 Apr 2021 08:54:35 GMT, Sebastian Stenzel wrote: When we do byte b1 = (byte) (value & 0xFF); we keep from int only 1 lower byte and exactly the same can be achieved with plain cast. See the test below: public class Main { public static voi

Re: RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Daniel Fuchs
On Thu, 8 Apr 2021 08:54:35 GMT, Sebastian Stenzel wrote: >> When we do >> byte b1 = (byte) (value & 0xFF); >> we keep from int only 1 lower byte and exactly the same can be achieved with >> plain cast. See the test below: >> public class Main { >> public static void main(String[] args) throw

Re: RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Sebastian Stenzel
On Thu, 4 Mar 2021 12:16:29 GMT, Сергей Цыпанов wrote: > When we do > byte b1 = (byte) (value & 0xFF); > we keep from int only 1 lower byte and exactly the same can be achieved with > plain cast. See the test below: > public class Main { > public static void main(String[] args) throws Excepti

Re: RFR: 8263561: Re-examine uses of LinkedList

2021-04-08 Thread Сергей Цыпанов
On Mon, 15 Mar 2021 06:56:00 GMT, Alan Bateman wrote: >> Nothing outside of the JDK should be hacking into this private field of a >> non-exposed class, this should not be a concern here. > >> @AlanBateman so is it ok to keep `ArrayLists`? > > One thing to look out for is usages of 2-arg add me

RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Сергей Цыпанов
When we do byte b1 = (byte) (value & 0xFF); we keep from int only 1 lower byte and exactly the same can be achieved with plain cast. See the test below: public class Main { public static void main(String[] args) throws Exception { IntStream.range(Integer.MIN_VALUE, Integer.MAX_VALUE).forEach