On Wed, 23 Jun 2021 18:02:02 GMT, Julia Boes wrote:
>> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
>> following format: First character uppercase, all other characters lowercase,
>> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
>> mutator m
On Thu, 24 Jun 2021 11:44:19 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Wed, 23 Jun 2021 18:02:02 GMT, Julia Boes wrote:
>> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
>> following format: First character uppercase, all other characters lowercase,
>> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
>> mutator m
On Thu, 24 Jun 2021 11:44:19 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Thu, 24 Jun 2021 14:22:21 GMT, Alan Bateman wrote:
>> I've created an issue to track this:
>> https://bugs.openjdk.java.net/browse/JDK-8269288
>
>> I've created an issue to track this:
>> https://bugs.openjdk.java.net/browse/JDK-8269288
>
> Thanks. So are you keeping the Objects.requireNonN
On Wed, 23 Jun 2021 18:02:02 GMT, Julia Boes wrote:
>> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
>> following format: First character uppercase, all other characters lowercase,
>> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
>> mutator m
On Thu, 24 Jun 2021 11:39:02 GMT, Patrick Concannon
wrote:
> I've created an issue to track this:
> https://bugs.openjdk.java.net/browse/JDK-8269288
Thanks. So are you keeping the Objects.requireNonNull here? If so then it
should probably be the 2-arg version so that the message is clear that
On Wed, 23 Jun 2021 15:09:28 GMT, Alan Bateman wrote:
>> @AlanBateman
>>
>> `protected DatagramSocket(DatagramSocketImpl impl)` throws NPE if `impl` is
>> `null`.
>> (this is covered by the blanket statement for NPE)
>>
>> Do we really need to specify anything else since the global
>> `setD
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
On Wed, 23 Jun 2021 13:09:53 GMT, Alan Bateman wrote:
> I assume DatagramSocket L1043-L1049 (declaration/init of
> USE_PLAINDATAGRAMSOCKET) can be removed too.
USE_PLAINDATAGRAMSOCKET removed as requested. See 49125e7
> src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 69:
>
>> 6
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
11 matches
Mail list logo
