**Issue**
A failure in this test was observed whereby an unexpected connection from a
client that was not created by the test caused the test to unsucessfully
complete.
**Solution**
When a connection is accepted by the ServerSocket, some verification of the
Request URI and of the Request Path
On Wed, 8 Jun 2022 18:29:10 GMT, Conor Cleary wrote:
> **Issue**
> It was observed that when the httpclient sends a POST request with the
> `Expect: 100 Continue` header set and the server replies with a response code
> `417 Expectation Failed` that the httpclient hangs indef
is returned
> to the client as a failed future, A unit test was added to ensure that this
> usage of the httpclient does not cause hanging.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8286171: Updated comment
-
C
On Thu, 9 Jun 2022 11:49:52 GMT, Jaikiran Pai wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8286171: Package-protected access for method
>> - 8286171: Added checks for correct re
On Thu, 9 Jun 2022 11:09:23 GMT, Conor Cleary wrote:
>> Yes - good catch!
>
> Good suggestion, no need for it to be public. Will do.
I made this change but added protected by mistake instead of just removing the
modifier. Will fix in subsequent change
On Thu, 9 Jun 2022 11:06:11 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java
>> line 424:
>>
>>> 422: }
>>> 423:
>>> 424: public void closeWhenFinished() {
>>
>> Hello Conor, do you think it might be better if we make this package
is returned
> to the client as a failed future, A unit test was added to ensure that this
> usage of the httpclient does not cause hanging.
Conor Cleary has updated the pull request incrementally with two additional
commits since the last revision:
- 8286171: Package-protected access for meth
On Wed, 8 Jun 2022 18:29:10 GMT, Conor Cleary wrote:
> **Issue**
> It was observed that when the httpclient sends a POST request with the
> `Expect: 100 Continue` header set and the server replies with a response code
> `417 Expectation Failed` that the httpclient hangs indef
**Issue**
It was observed that when the httpclient sends a POST request with the `Expect:
100 Continue` header set and the server replies with a response code `417
Expectation Failed` that the httpclient hangs indefinitely when the version of
Http used is HTTP/2. However, it was also seen that
On Tue, 29 Mar 2022 15:44:58 GMT, Conor Cleary wrote:
> **Issue**
> When using the `HttpClient.send()` to send a GET request created using the
> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
> behaviour causes issues with many services as a body re
On Thu, 12 May 2022 12:23:34 GMT, Jaikiran Pai wrote:
>> Will await further review for a short while and then integrate if approved.
>
>> Will await further review for a short while and then integrate if approved.
>
> Hello Conor, looking at the latest state of the PR, I think you might have
>
On Tue, 3 May 2022 15:00:51 GMT, Conor Cleary wrote:
> **Issue**
> A recent fix for
> [JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
> addressed the httpclient being unable to properly process Http/2 PushPromise
> frames followed by continuations caus
ctice), a `Content-length` header with the appropriate value will be
> added.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8283544: Added in missing case
-
Changes:
- all: https://git.openjdk.java.ne
On Thu, 12 May 2022 12:23:34 GMT, Jaikiran Pai wrote:
>> Will await further review for a short while and then integrate if approved.
>
>> Will await further review for a short while and then integrate if approved.
>
> Hello Conor, looking at the latest state of the PR, I think you might have
>
On Thu, 12 May 2022 11:54:55 GMT, Conor Cleary wrote:
>> **Issue**
>> A recent fix for
>> [JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
>> addressed the httpclient being unable to properly process Http/2 PushPromise
>> frames fo
On Fri, 6 May 2022 13:46:41 GMT, Conor Cleary wrote:
>> **Issue**
>> When using the `HttpClient.send()` to send a GET request created using the
>> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
>> behaviour causes issues with many services
On Thu, 5 May 2022 13:37:08 GMT, Conor Cleary wrote:
>> **Issue**
>> A recent fix for
>> [JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
>> addressed the httpclient being unable to properly process Http/2 PushPromise
>> frames fo
d in the test itself. This prevents the situation of unexpected frames
> being sent before a Continuation Frame was meant to arrive.
>
> In addition to the above, Http2Connection was modified to ensure that a
> connection error of type PROTOCOL_ERROR is thrown if a frame other than a
&
ctice), a `Content-length` header with the appropriate value will be
> added.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8283544: Removed unecessary control flow
-
Changes:
- all: https://git.openjdk.java.ne
ctice), a `Content-length` header with the appropriate value will be
> added.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8283544: Improved logging, drain input stream
-
Changes:
- all: https://git.openjdk.
d in the test itself. This prevents the situation of unexpected frames
> being sent before a Continuation Frame was meant to arrive.
>
> In addition to the above, Http2Connection was modified to ensure that a
> connection error of type PROTOCOL_ERROR is thrown if a frame other than a
&
On Wed, 4 May 2022 11:17:32 GMT, Daniel Fuchs wrote:
>> **Issue**
>> A recent fix for
>> [JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
>> addressed the httpclient being unable to properly process Http/2 PushPromise
>> frames followed by continuations caused
On Wed, 4 May 2022 11:13:26 GMT, Daniel Fuchs wrote:
>> **Issue**
>> A recent fix for
>> [JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
>> addressed the httpclient being unable to properly process Http/2 PushPromise
>> frames followed by continuations caused
On Wed, 4 May 2022 11:05:56 GMT, Daniel Fuchs wrote:
>> **Issue**
>> A recent fix for
>> [JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
>> addressed the httpclient being unable to properly process Http/2 PushPromise
>> frames followed by continuations caused
**Issue**
A recent fix for
[JDK-8263031](https://bugs.openjdk.java.net/browse/JDK-8263031), which
addressed the httpclient being unable to properly process Http/2 PushPromise
frames followed by continuations caused intermittent failures of the test. This
was cause by two seperate problems.
-
On Thu, 7 Apr 2022 13:53:35 GMT, Conor Cleary wrote:
>> **Issue**
>> When using the `HttpClient.send()` to send a GET request created using the
>> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
>> behaviour causes issues with many services
ctice), a `Content-length` header with the appropriate value will be
> added.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8283544: Updated URI creation
-
Changes:
- all: https://git.openjdk.java.ne
On Fri, 4 Mar 2022 14:42:40 GMT, Conor Cleary wrote:
> **Problem**
> When a Continuation Frame is received by the httpclient using HTTP/2 after a
> Push Promise frame (can happen if the amount of headers to be sent in a
> single Push Promise frame exceeds the maximum fr
ctice), a `Content-length` header with the appropriate value will be
> added.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8283544: Moved test assertions out of HttpHandlers
-
Changes:
- all: https://git.openjdk.
On Wed, 30 Mar 2022 08:29:40 GMT, Conor Cleary wrote:
>> **Issue**
>> When using the `HttpClient.send()` to send a GET request created using the
>> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
>> behaviour causes issues with many services
On Tue, 29 Mar 2022 17:09:37 GMT, Daniel Fuchs wrote:
> I would not expect that throwing an AssertionError in the handler on the
> server side would make the client (and the test) fail (except maybe in
> timeout?). I'd suggest printing a message on System.err and sending a
> different error
ctice), a `Content-length` header with the appropriate value will be
> added.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8283544: Removed testing comments
-
Changes:
- all: https://git.openjdk.java.ne
On Tue, 29 Mar 2022 18:23:02 GMT, Daniel Jeliński wrote:
>> **Issue**
>> When using the `HttpClient.send()` to send a GET request created using the
>> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
>> behaviour causes issues with many services as a body related header is
**Issue**
When using the `HttpClient.send()` to send a GET request created using the
`HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This behaviour
causes issues with many services as a body related header is usually not
expected to be included with a GET request.
On Fri, 25 Mar 2022 15:55:54 GMT, Conor Cleary wrote:
>> Oh yes, good point. I think `ErrorFrame.PROTOCOL_ERROR` would be the most
>> appropriate here. I'll amend the change accordingly.
>
> However, I'll look into the specification further for the other cases and see
> if
A regression test was included which verifies that the exception is not
> thrown and that the headers arrive correctly.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8263031: changed to ErrorFrame.PROTOCOL_ERROR
-
C
On Fri, 25 Mar 2022 15:51:44 GMT, Conor Cleary wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
>> line 807:
>>
>>> 805: } catch (UncheckedIOException e) {
>>> 806: de
On Thu, 24 Mar 2022 18:21:45 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8263031: further verification of push promise and response
>> - 8263031: Re
On Tue, 15 Feb 2022 15:33:01 GMT, Conor Cleary wrote:
>> As described in the title, this is a simple change to the
>> `HttpRequest.Builder::build` method to highlight that an immutable and
>> reusable instance of an `HttpRequest` is created when this method is
>&g
On Tue, 22 Mar 2022 10:57:35 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - 8263031: Added return statements and pcs var
>> - 8263031: Test cleanup, added
A regression test was included which verifies that the exception is not
> thrown and that the headers arrive correctly.
Conor Cleary has updated the pull request incrementally with two additional
commits since the last revision:
- 8263031: further verification of push promise and respo
A regression test was included which verifies that the exception is not
> thrown and that the headers arrive correctly.
Conor Cleary has updated the pull request incrementally with four additional
commits since the last revision:
- 8263031: Added return statements a
A regression test was included which verifies that the exception is not
> thrown and that the headers arrive correctly.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8263031: Correct ordering of imports
-
Changes:
On Mon, 7 Mar 2022 12:08:49 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263031: Tidied up import statements
>
> src/java.net.http/share/classes/jdk/internal
A regression test was included which verifies that the exception is not
> thrown and that the headers arrive correctly.
Conor Cleary has updated the pull request incrementally with two additional
commits since the last revision:
- 8263031: Cleanup of changes in Http2Connection
- 826303
On Mon, 7 Mar 2022 12:31:41 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263031: Tidied up import statements
>
> src/java.net.http/share/classes/jdk/internal
On Mon, 14 Mar 2022 11:19:36 GMT, Conor Cleary wrote:
>> test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 176:
>>
>>> 174: ContinuationFrame cf = new ContinuationFrame(streamid,
>>> HeaderFrame.END_HEADERS, encodedHeaders);
>
On Mon, 7 Mar 2022 12:17:53 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263031: Tidied up import statements
>
> src/java.net.http/share/classes/jdk/internal
On Mon, 7 Mar 2022 12:28:29 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263031: Tidied up import statements
>
> test/jdk/java/net/httpclient/http2/PushPro
On Mon, 7 Mar 2022 08:23:46 GMT, Conor Cleary wrote:
>> **Problem**
>> When a Continuation Frame is received by the httpclient using HTTP/2 after a
>> Push Promise frame (can happen if the amount of headers to be sent in a
>> single Push Promise frame exceeds th
On Fri, 4 Mar 2022 15:17:11 GMT, Conor Cleary wrote:
> I see that a couple of imports got changed by my IDE, will address that
> shortly
Now resolved
-
PR: https://git.openjdk.java.net/jdk/pull/7696
A regression test was included which verifies that the exception is not
> thrown and that the headers arrive correctly.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8263031: Tidied up import statements
-
Changes:
On Fri, 4 Mar 2022 14:42:40 GMT, Conor Cleary wrote:
> **Problem**
> When a Continuation Frame is received by the httpclient using HTTP/2 after a
> Push Promise frame (can happen if the amount of headers to be sent in a
> single Push Promise frame exceeds the maximum fr
**Problem**
When a Continuation Frame is received by the httpclient using HTTP/2 after a
Push Promise frame (can happen if the amount of headers to be sent in a single
Push Promise frame exceeds the maximum frame size, so a Continuation frame is
required), the following exception occurs:
n `@implSpec`
> given [here](https://openjdk.java.net/jeps/8068562)).
>
> The detail added under the `@implSpec` Tag is similar to that provided at the
> interface-level Javadoc for Builder.
>
> Please also review the CSR for this change:
> https://bugs.openjdk.java.net/bro
On Tue, 15 Feb 2022 15:04:12 GMT, Daniel Fuchs wrote:
>> As described in the title, this is a simple change to the
>> `HttpRequest.Builder::build` method to highlight that an immutable and
>> reusable instance of an `HttpRequest` is created when this method is
>> invoked. This is done by
As described in the title, this is a simple change to the
`HttpRequest.Builder::build` method to highlight that an immutable and reusable
instance of an `HttpRequest` is created when this method is invoked. This is
done by adding an `@implSpec` Javadoc Tag (details on `@implSpec` given
On Mon, 12 Apr 2021 15:21:05 GMT, Conor Cleary wrote:
> ### Description
> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, both
> of which are explicity bound to a Link-Local address. Neither of the
> ServerSocket instances are explicitly cl
On Tue, 13 Apr 2021 09:04:02 GMT, Michael McMahon wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed othervm argument
>
> test/jdk/java/net/Inet6Address/B6206527.java line
On Tue, 13 Apr 2021 09:14:47 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/Inet6Address/B6206527.java line 31:
>>
>>> 29: * @build jdk.test.lib.NetworkConfiguration
>>> 30: *jdk.test.lib.Platform
>>> 31: * @run main/othervm B6206527
>>
>> Does it need othervm mode? Best to not use
### Description
`Inet6Address/B6206527.java` test creates two instances of ServerSocket, both
of which are explicity bound to a Link-Local address. Neither of the
ServerSocket instances are explicitly closed meaning there is no guarantee that
their associated resources are freed.
### Fix
Each
On Wed, 24 Feb 2021 10:24:06 GMT, Conor Cleary wrote:
> A number of net tests use a
> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
> to verify either the func
On Fri, 26 Feb 2021 10:44:04 GMT, Rahul Yadav wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed comment
>
> LGTM!
Ran the changes through `-Xdoclint:missing` and there were no warnings
outputted so looks
On Thu, 25 Feb 2021 17:26:00 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8262195: Copyrights & InternalNSTest Host File Delete
>> - 8262195: Added
ple of one the fixes...
> * @run main/othervm -Djdk.net.hosts.file=TestToNumericFormatHosts
> textToNumericFormat
Conor Cleary has updated the pull request incrementally with two additional
commits since the last revision:
- 8262195: Copyrights & InternalNSTest Host File Delete
- 8262195:
On Wed, 24 Feb 2021 16:10:01 GMT, Aleksei Efimov wrote:
>> A number of net tests use a
>> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
>> to verify either the functionality of
On Wed, 24 Feb 2021 15:57:49 GMT, Aleksei Efimov wrote:
>> A number of net tests use a
>> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
>> to verify either the functionality of
On Wed, 24 Feb 2021 10:24:06 GMT, Conor Cleary wrote:
> A number of net tests use a
> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
> to verify either the func
A number of net tests use a
**[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
to verify either the functionality of this type of Name Service or as a
complement to other tests (such
On Thu, 18 Feb 2021 10:12:30 GMT, Conor Cleary wrote:
>>> I think that the changes are mostly good. I would like to try them out on
>>> my local system and our internal buildAndTest system.
>>
>> Chris, were you able to test the patch?
>>
>> Als
On Fri, 19 Feb 2021 14:48:39 GMT, Conor Cleary wrote:
>> Jamie Le Tual has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed formatting
>
> src/java.base/unix/native/libnet/Inet4AddressImpl.c line 375:
>
On Wed, 23 Dec 2020 14:06:12 GMT, Jamie Le Tual
wrote:
>> Users have been able to send ICMP packets without the need for root
>> privileges or the CAP_NET_RAW capability since at least kernel 3.11.
>>
>> For some time now, if the kernel parameter net.ipv4.ping_group_range
>> included the gid
On Tue, 16 Feb 2021 13:37:20 GMT, Jamie Le Tual
wrote:
> > I think that the changes are mostly good. I would like to try them out on
> > my local system and our internal buildAndTest system.
>
> Chris, were you able to test the patch?
>
> Also if anyone has an idea as to the best way to unit
On Mon, 7 Dec 2020 09:52:47 GMT, Conor Cleary wrote:
> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
> seen to fail with an IllegalMonitorStateException. This failure was caused by
> the use of `wait()` in a non synchronized block. This failure was
On Mon, 7 Dec 2020 14:53:25 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8255583: Added original bug id to bug tag
>> - 8255583: Add bug & summary tags t
e code throwing the exception was fixed, a regression test was not
> made. So this patch adds a simple white-box test which calls the
> KeepAliveStreamCleaner's run method. `waiter.wait()` should always fail if
> not used in a synchronized block or method, so the test verifies that it is
On Mon, 7 Dec 2020 11:09:47 GMT, Conor Cleary wrote:
>> Will do Daniel, thanks for pointing that out!
>
> Should probably add a short summary as well
Added bug ids for the original issue which you referred to and for the issue
this PR relates to. Will mark as resolved if this
On Mon, 7 Dec 2020 10:55:06 GMT, Daniel Fuchs wrote:
>> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
>> seen to fail with an IllegalMonitorStateException. This failure was caused
>> by the use of `wait()` in a non synchronized block. This failure was
>> mitigated
The KeepAliveStreamCleaner in sun.net.ww.http package had been previously seen
to fail with an IllegalMonitorStateException. This failure was caused by the
use of `wait()` in a non synchronized block. This failure was mitigated through
use of `await()` instead as is shown below (code can be
On Thu, 5 Nov 2020 12:46:08 GMT, Conor Cleary wrote:
> The primary goal of this fix was to refactor
> NetworkInterface/UniqueMacAddressesTest.java to make use of the
> jdk.test.lib.NetworkConfiguration class instead of java.net.NetworkInterface.
> This was due to the original f
On Thu, 5 Nov 2020 16:30:31 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8246741: Corrected summary tag, moved record declaration
>
> test
additional
> logging of, for example, the list of present interfaces returned by
> createNetworkInterfaceList() if deemed necessary by review.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8246741: Added descriptive comment to record
additional
> logging of, for example, the list of present interfaces returned by
> createNetworkInterfaceList() if deemed necessary by review.
Conor Cleary has updated the pull request incrementally with one additional
commit since the last revision:
8246741: Corrected summary tag, moved record declaration
-
On Thu, 5 Nov 2020 14:10:15 GMT, Patrick Concannon
wrote:
> Great work, Conor. The test looks much better!
>
> Did you consider using testNG? Might help you condense things a bit more
Thanks @pconcannon!
I definitely do prefer testNG but was keen not to venture any further away from
the
The primary goal of this fix was to refactor
NetworkInterface/UniqueMacAddressesTest.java to make use of the
jdk.test.lib.NetworkConfiguration class instead of java.net.NetworkInterface.
This was due to the original failure being related to the use of the 'awdl'
interface on macOS, which
On Wed, 30 Sep 2020 10:22:11 GMT, Conor Cleary wrote:
> This patch replaces a LinkedList data structure used in the
> net.http.Http2Connection class with an ArrayList. This
> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
> java.net](https://bugs.openjdk.jav
On Tue, 6 Oct 2020 17:04:01 GMT, Aleksey Shipilev wrote:
> I can sponsor this, but it is not clear what testing was done on this. At
> least `tier1`?
`tier1`, `tier2`, `jdk_net`, `test/jdk/java/net/httpclient` tests were
conducted with all passing.
-
PR:
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote:
>> This patch replaces a LinkedList data structure used in the
>> net.http.Http2Connection class with an ArrayList. This
>> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
>> java.net](https://bugs
O(N-1) for LinkedLists
> - While insertion operations can be expensive (O(N) in the worst case), these
> operations appear to be
> infrequent/non-existent in this case.
>
> Additional justifications or challenges to those listed are welcome! The
> general idea is that ArrayLists
On Thu, 1 Oct 2020 09:43:46 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
>> line 703:
>>
>>> 701: if (initialCause == null) this.cause = t;
>>> 702: client2.deleteConnection(this);
>>> 703: List> c = new
This patch replaces a LinkedList data structure used in the
net.http.Http2Connection class with an ArrayList. This
issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
java.net](https://bugs.openjdk.java.net/browse/JDK-8246048).
Some justifications for this change are as follows:
to revert the changes at lines:
66,67,144 and 145.
(and that will be much simpler in the bargain :-) )
best regards,
-- daniel
On 14/08/2020 15:37, Conor Cleary wrote:
Hi all,
Requesting some reviewers for a patch concerning JDK-8246047 'Replace
LinkedList impl in net.http.websocket.BuilderImpl
Hi all,
Requesting some reviewers for a patch concerning JDK-8246047 'Replace
LinkedList impl in net.http.websocket.BuilderImpl'. This patch replaces
LinkedList data structures used in the net.http.websocket BuilderImpl
class with ArrayLists. In particular, the 'headers' and 'subprotocols'
Hi,
Could someone please take a look at my webrev for JDK-8246143:
'UnreferencedXXX tests fail when run with --illegal-access=deny'?
This patch addresses test failures with
test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java and
94 matches
Mail list logo
