Re: Code Review Request: 7171415: java.net.URI.equals/hashCode not consistent for some URIs

2013-01-08 Thread David Schlosnagle
On Tue, Jan 8, 2013 at 10:57 PM, Kurchi Subhra Hazra wrote: > On 1/8/13 6:39 PM, David Schlosnagle wrote: >> >> Hi Kurchi, >> >> I had a couple quick comments: >> >> On line 1756, you might want to allocate the StringBuilder normalizedS >> = new String

Re: Code Review Request: 7171415: java.net.URI.equals/hashCode not consistent for some URIs

2013-01-08 Thread David Schlosnagle
Hi Kurchi, I had a couple quick comments: On line 1756, you might want to allocate the StringBuilder normalizedS = new StringBuilder(s.length()); to avoid resizing during the appending. On line 1754 and 1759, is it worth restructuring the logic to avoid performing indexOf twice to find the first