/~xiaofeya/8169115/webrev.02/
>
> Thanks,
> Felix
> On 2016/12/6 19:16, Dmitry Samersoff wrote:
>> Felix,
>>
>> 1. I'm not sure that javaweb.sfbay.sun.com is the best domain name for
>> this test. Could we use different one (e.g. icann.org)
>>
>> 2. This
owing patch. It generally coverts codes from
> shell to plain java.
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8169115
>
> Webrev:
>
> http://cr.openjdk.java.net/~xiaofeya/8169115/webrev.00/
>
> Thanks,
>
> Felix
>
--
Dmitry Samerso
here is some concern about the potential performance effect, etc,
>>>> of gettimeofday, maybe there is a way out of this. The reuse of
>>>> NET_Timeout is good, but it also calls gettimeofday. It seems that
>>>> a specific NET_ReadWithTimeout could be written to
onsistent with the existing code.
>
> Thanks,
>
> Vyom
>
>
> On Friday 02 September 2016 01:38 AM, Dmitry Samersoff wrote:
>> Vyom,
>>
>> Did you consider to use select() to calculate timeout instead of
>> gettimeofday ?
>>
>> gettimeo
browse/JDK-8075484
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~vtewari/8075484/webrev0.0/index.html
>>>> <http://cr.openjdk.java.net/%7Evtewari/8075484/webrev0.0/index.html>
>>>>
>>>> This issue is Socket
lso, is there any way to detect a FIN
> in the JVM and react on it?
>
>
>
> Thanks in advance and best regards
>
> Christoph
>
>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
Chris,
Looks good for me. Only minor nits (no need to re-review).
1040 missed space before {
1158 please, add comment and {} around continue.
1938 I'm not sure that check for IFF_POINTOPOINT is necessary (but
don't mid to leave it). Do you know the case when both flags are set?
-Dmitry
On
Additional minor fixes and cleanups in
>>> NetworkInterface.c
>>>
>>> As a follow up to JDK-8156521, and when comparing against the
>>> version of this file in jdk8u-dev a few minor issues were noticed.
>>>
>>> There is a free of a memory struct
ke sure
> nothing broke.
>
>
>
> Thanks in advance
>
> Christoph
>
>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
://e61b615da46327c9050d624b0a3783ba21c6b125.googledrive.com/host/0B5Kp-cB1sXJrfnZ4NHZ0S1V3UTJZcDFra3RwUFZjQXY5WVZzUkwtTTd0Z1IyR1JmbDZPSVk/resolvconf-reinit/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
, isa_class, isa_ctorID, ia, port);
(*env)-SetObjectArrayElement(env, isaa, 0, isa);
-Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
wrote:
On 18 Dec 2014, at 12:22, Dmitry Samersoff dmitry.samers...@oracle.com
wrote:
Chris,
In a windows world it's rather common to rely on socket inheritance
e.g. set socket to stdin(stdout) of child process and do CreateProcess.
OK, but there can be no expectation that something like
},
{1024.1.2.3, null},
{128.14.66000, null }
regards
Mark
On 30/09/2014 18:53, Dmitry Samersoff wrote:
Mark,
It probably should be some-name.invalid
IANA reserve .invalid TLD for tests like this one
see:
http://www.iana.org/assignments/special-use-domain
this highlights a DNS configuration issue as indicated in
https://www.icann.org/resources/pages/name-collision-2013-12-06-en
so we remove foo.bar from the test and replace with somehost.some-domain
regards
Mark
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I
:
On 22 Feb 2014, at 17:23, Dmitry Samersoff
dmitry.samers...@oracle.com wrote:
Chris,
Didn't look to windows part. Unix part looks good for me. See also
below.
I'm a bit concerned because of mixing NET_* abstractions and direct
call
to OS functions. It might be better to create NET_socket etc
tracks changing the native in src/share/native/java/net and
src/solaris/native/java/net so that the system calls are used directly rather
than going through the JVM_* functions.
http://cr.openjdk.java.net/~chegar/8034174/webrev.00/webrev/
-Chris.
--
Dmitry Samersoff
Oracle Java
Changeset: 392acefef659
Author:dsamersoff
Date: 2013-10-19 20:59 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/392acefef659
8024071: In ManagementAgent.start it should be possible to set the jdp.name
parameter.
Summary: Pass one more property from Agent to JdpController
because
it went through so many iterations).
-Alan.
Yes I will create a new one, thanks.
Brian
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
errors are handle translated
consistently.
See https://bugs.openjdk.java.net/browse/JDK-4842142.
Brian
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
?
New webrev at:
http://cr.openjdk.java.net/~robm/7180557/webrev.04/
-Rob
On 21/09/13 12:20, Dmitry Samersoff wrote:
Rob,
See below -
ll. 210 have to be fixed, other comments is just an opinion.
Inet4AddressImpl.c:
ll.132 - it might be better to move initialization to a separate
Rob,
Existing code uses if (JVM_GetHostName(myhostname, NI_MAXHOST)) so I
withdraw my last comments. Please, don't change it!!!
-Dmitry
On 2013-10-07 20:30, Rob McKenna wrote:
Thanks Dmitry! I'll correct that nipick pre-push.
-Rob
On 07/10/13 16:47, Dmitry Samersoff wrote:
Rob
result
or timeout, but it requires much more work and probably out of scope of
this CR.
-Dmitry
On 2013-10-03 13:11, Chris Hegarty wrote:
On 10/02/2013 11:18 PM, Dmitry Samersoff wrote:
Chris,
I'm not sure immediate native retry make sence here because tipically
EAGAIN of getaddrinfo caused
Changeset: 5d6dc0cba08f
Author:dsamersoff
Date: 2013-10-03 16:54 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d6dc0cba08f
8009213: sun/management/jdp/JdpTest.sh fails with exit code 1
Summary: There's no guarantee that the java process has executed far enough to
be found
in the Java layer, perhaps with
a very short wait?
native, without any wait, should be sufficient.
B) Should the message or cause in #2 be explicitly document in the
javadoc?
I don't think it is necessary for this to be documented. It is more
informational.
-Chris.
--
Dmitry Samersoff
(not a reviewer)
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
is getaddrinfo returning EAGAIN or is it failing with EAI_SYSTEM and
errno set to EAGAIN? I also wonder if the EAGAIN means the underlying
syscall has been interrupted, in which case the normal thing to do is to
retry.
-Alan
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg
a fallback only
on MACOSX (and there is certainly no need to prefer the fallback then).
Gruss
Bernd
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
: https://bugs.openjdk.java.net/browse/JDK-8024952
webrev : http://cr.openjdk.java.net/~coffeys/webrev.8024952/webrev/
Regards,
Sean.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the source code.
address
webrev:
http://cr.openjdk.java.net/~msheppar/8021372/webrev.01/
regressions re-run with no ill effects
regards
Mark
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
.
http://cr.openjdk.java.net/~robm/7180557/webrev.01/
-Rob
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
this is the way to go so I figured trial
by fire might get the discussion going.
http://cr.openjdk.java.net/~robm/7180557/webrev.01/
-Rob
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
with the
setting of a default index to 0 in the Java NetworkInterface abstraction,
where a defaultIndex of zero is used.
JPRTs have been run and show no side effects.
regards
Mark
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world
in
SNIHostName
But, I guess that is where it should be enforced if it is required.
Michael.
On 06/08/13 17:43, Dmitry Samersoff wrote:
Xuelei,
. (dot) is perfectly valid domain name and it means root domain so
com.
is valid domain name as well.
It thinks to me that in context of methods your
for example..com.
Does it make sense?
Thanks,
Xuelei
On 8/7/2013 1:35 AM, Michael McMahon wrote:
I don't really understand the reason for the restriction in SNIHostName
But, I guess that is where it should be enforced if it is required.
Michael.
On 06/08/13 17:43, Dmitry Samersoff
Changeset: fce446b29577
Author:dsamersoff
Date: 2013-08-06 14:04 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fce446b29577
8011038: sourceObj validation during desereliazation of RelationNotification
should be relaxed
Summary: sourceObj could be set to null by setSource()
,
Xuelei
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
initInetAddrs ( or something similar ).
-Chris.
This low-risk fix will hopefully be going into 7u40.
Bug: http://bugs.sun.com/view_bug.do?bug_id=8020498
Webrev: http://cr.openjdk.java.net/~khazra/8020498/webrev.00/
Thanks,
Kurchi
--
Dmitry Samersoff
Oracle Java development team
]
if (cookieHandler == null || value.length() == 0)
return value;
So return value is not changed. BTW. I agree with your comments.
-Chris.
On 06/27/2013 06:13 PM, Dmitry Samersoff wrote:
Chris,
1. I'm not sure it's a correct to return null rather then empty
/webrev.02/
http://cr.openjdk.java.net/%7Ejzavgren/8015799/webrev.02/
The problem I fixed occurs when a server returns an array of cookies
that contains a null cookie.
Thanks
John
--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA
--
-Kurchi
--
Dmitry Samersoff
Changeset: df1b35c7901d
Author:dsamersoff
Date: 2013-06-05 18:20 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df1b35c7901d
8015604: JDP packets containing ideographic characters are broken
Summary: Code uses string length rather than byte array length and non ascii
entry
Changeset: 7d7bfce34a79
Author:dsamersoff
Date: 2013-05-28 18:46 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7bfce34a79
8014420: Default JDP address does not match the one assigned by IANA
Summary: JDP protocol defaults changed to IANA assigned values
Reviewed-by:
is integrated, I will
change the doPrivileged() call to limit the privilege elevation to a single
SocketPermission (as shown in the code comments).
The webrev is at http://cr.openjdk.java.net/~michaelm/8010464/webrev.1/
Thanks
Michael
--
Dmitry Samersoff
Oracle Java development team, Saint
Alan,
Not sure what is real usecase for this requirements for ipv4.
For ipv6 it should be done by sendmsg() and msg_control.
-Dmitry
On 2013-05-06 11:28, Alan Bateman wrote:
On 05/05/2013 12:19, Dmitry Samersoff wrote:
Alan,
SO_BINDTODEVICE shouldn't be used in modern applications because
SocketChannel configured non-blocking plus a Selector. This may not be
what you are thinking of course.
-Alan.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
/
In addition to defining a new permission class, HttpURLConnection
is modified to make use of it and the documentation change
describing this
can be seen at the link below:
http://cr.openjdk.java.net/~michaelm/8010464/api/blender.html
All comments welcome.
Thanks
Michael.
--
Dmitry
wrote:
On 01/05/13 11:09, Dmitry Samersoff wrote:
Michael,
GET,POST:Header1,Header2
Colon is a delimiter between http header and it's value.
With this syntax we might have problems in a future if sometimes we will
support different headers for different methods or add an ability to
check
:11, Dmitry Samersoff wrote:
Michael,
I'm just asking about replacing : (colon) to another character to be
able to write something like:
permission
java.net.HttpURLPermission http://www.foo.com/-;,
GET Location: http://www.foo.com/*, Content-type: image/jpeg;
in a future
-Dmitry
- Michael
On 01/05/13 12:38, Dmitry Samersoff wrote:
Michael,
Sorry for not being clean enough.
On my opinion an ability to check header value as well as a header name
is quite useful future for the real world.
e.g. to being able to prevent redirection to other domain or limit
certain
/webrev.03/
Thanks!
John
On 04/20/2013 10:36 AM, Kurchi Subhra Hazra wrote:
On Apr 20, 2013, at 4:40 AM, Dmitry Samersoff dmitry.samers...@oracle.com
wrote:
Kurchi,
if *netaddrPP == NULL at 367 and calloc fails at 391 we would jump
to freeAllocatedMemory with start == NULL
True
start-next).
If you see any errors in my thinking, please let me know.
Thanks!
John
On 04/20/2013 07:40 AM, Dmitry Samersoff wrote:
Kurchi,
if *netaddrPP == NULL at 367 and calloc fails at 391 we would jump
to freeAllocatedMemory with start == NULL
I have no ideas whether this code
:16 AM, Dmitry Samersoff dmitry.samers...@oracle.com
wrote:
John,
102, 145 else is redundant.
438 - we will crash here if start is null
Maybe it is good to have an additional check for start != null, but from what
I see, start will not be null if *netaddrPP is not null
/~chegar/8012244/webrev.00/webrev/
-Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
Dmitry,
I'm not 100% sure what you mean by duplication, the exceptions and their
messages are distinct. I think it would be best to keep it that way.
-Rob
On 07/03/13 22:00, Dmitry Samersoff wrote:
Rob,
Is it possible to avoid code duplication?
i.e. do something like this:
int
John,
closesocket call should be here.
-Dmitry
On 2013-03-04 20:12, John Zavgren wrote:
Greetings:
I posted a webrev image for a modification that eliminates a file descriptor
leak.
http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/
Thanks!
John
--
Dmitry Samersoff
Oracle
Changeset: 8181be9a3538
Author:dsamersoff
Date: 2013-02-13 21:06 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8181be9a3538
8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris
Summary: fixed couple of more Solaris shell incompatibilities
Reviewed-by: chegar
Changeset: 1df991184045
Author:dsamersoff
Date: 2013-02-11 18:44 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1df991184045
8007536: Incorrect copyright header in JDP files
Summary: Copyright header in JDP files missed the classpath exception rule.
Reviewed-by: mikael
!
Changeset: 0e7d5dd84fdf
Author:dsamersoff
Date: 2013-02-06 16:53 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e7d5dd84fdf
8007277: JDK-8002048 testcase fails to compile
Summary: sun.* classes is not included to ct.sym file and symbol file have to
be ignored
Reviewed-by:
Changeset: 962d6612cace
Author:dsamersoff
Date: 2013-02-03 21:39 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/962d6612cace
8002048: Protocol to discovery of manageable Java processes on a network
Summary: Introduce a protocol to discover manageble Java instances across a
://cr.openjdk.java.net/~chegar/8006395/webrev.00/webrev/
-Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
/webrevs/jzavgren/8005120/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
they are used to define buffer lengths.
Were one to supply a negative value as an argument, it would be cast
into an unsigned Martian value and there'd be (hopefully) a system
call error.
Thanks!
John Zavgren
http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/
--
Dmitry
Changeset: 3f014bc09297
Author:dsamersoff
Date: 2012-12-20 17:24 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f014bc09297
7009998: JMX synchronization during connection restart is faulty
Summary: add a return statement after the re-connecting has finished and the
state
/jzavgren/8005120/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
Changeset: c1a55ee9618e
Author:dsamersoff
Date: 2012-12-20 20:12 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1a55ee9618e
8005309: Missed tests for 6783290,6937053,7009998
Summary: Missed tests for 6783290,6937053,7009998
Reviewed-by: sjiang, emcmanus
Contributed-by:
a
negative value as an argument, it would be cast into an unsigned Martian
value and there'd be (hopefully) a system call error.
Thanks!
John Zavgren
http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
, it would be cast into an unsigned Martian
value and there'd be (hopefully) a system call error.
Thanks!
John Zavgren
http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always
/~mullan/webrevs/jzavgren/8005120/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
or host name. It is
simply replying to the initial/opening SOCKS handshake.
The updated host name is still brittle ( if a .t TLD is ever registered!
). I don't have a better alternative.
-Chris.
-Alan
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit
On 2012-12-12 22:29, Chris Hegarty wrote:
On 12/12/2012 18:15, Dmitry Samersoff wrote:
Chris,
According to rfc2606 TLD .invalid is reserved for cases like this one,
Yes, I came across this, but there is nothing to stop an internal DNS
server from resolving .invalid domains. Anyway, may
that?
Best regards,
Frank
On 12/10/2012 3:43 PM, Dmitry Samersoff wrote:
Frank,
Looks good for me.
May be Can't get WIDE string should be changed to something more
verbose.
-Dmitry
On 2012-12-10 11:40, Frank Ding wrote:
Hi Dmitry and Chris,
Could you please review the second revision
and proxies.
Thanks
Michael
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
see a comment // MMM 7200720 ??
at ll: 202 of NTLMAuthentication.java
- Does it make sense to change it to something more verbose?
Otherwise looks good for me.
http://cr.openjdk.java.net/~michaelm/8003948.7u-dev/webrev.1/
Looks good for me.
-Dmitry
--
Dmitry Samersoff
Oracle Java
/
-Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
, Dmitry Samersoff wrote:
Frank,
Changes look good for me.
I admit that I am not an expert in this area, but given the
information you provided, and I guess you verified this in your
environment, the conversion would appear reasonable.
But it might be better to fall back to original
that will follow this one
related to this problem. But, I'd like to go ahead and push this one first
if possible
- Michael
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
where isClosedOrPending()
grabs the fdLock to check if the socket is closed, or not, and the
construction of the in/output stream, where another thread may
asynchronously close the socket.
http://cr.openjdk.java.net/~chegar/8003833/webrev.00/webrev/
-Chris.
--
Dmitry Samersoff
Oracle
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
/10300670.aspx
You comments are appreciated.
Best regards,
Frank
--
Dmitry Samersoff
Saint Petersburg, Russia, http://devnull.samersoff.net
* There will come soft rains ...
/~chegar/8002297/webrev.00/webrev/
-Chris
--
Dmitry Samersoff
Java development team, SPB04
* There will come soft rains ...
On 2012-11-06 15:41, Chris Hegarty wrote:
On 11/06/2012 11:30 AM, Dmitry Samersoff wrote:
Chris,
If you need definitely refusing port the best option is use port 0
reserved by IANA for this purpose.
Do you have a link specifying this? I don't see this behavior on my
Solaris box.
http
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
a false positive from our static code analyzer: parfait. This modification
doesn't change any of the externally-visible behavior in the procedure.
I look forward to your comments and suggestions.
Thanks!
John Zavgren
john.zavg...@oracle.com
--
Dmitry Samersoff
Java Hotspot
Changeset: b2d8a99a049e
Author:dsamersoff
Date: 2012-10-17 18:34 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2d8a99a049e
6809322: javax.management.timer.Timer does not fire all notifications
Summary: Some notifications get dropped due to ConcurrentModificationException
don't continue to
include it, rather just removing the guarantee that it is always
present. The motivation for bringing this up is modules and compact
profiles where it might be desirable to not include the ftp protocol
handler for footprint reasons.
-Alan
--
Dmitry Samersoff
Java Hotspot
Changeset: 0c1c4b185451
Author:dsamersoff
Date: 2012-09-29 15:44 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c1c4b185451
7186723: TEST_BUG: Race condition in
sun/management/jmxremote/startstop/JMXStartStopTest.sh
Summary: Make test self-terminating and independent to
assume it's
better to put minor harmless tweaks in our code than to add state information
to parfait, that would cause it to ignore certain situations. That option
seems complicated and dangerous.
Thanks!
John Zavgren
john.zavg...@oracle.com
--
Dmitry Samersoff
Java Hotspot
sofa so garish as to require one to
wear peril sensitive sunglasses.
Personally, I also don't think that the coding style is important. It's
important to have the style common one over all code - which one doesn't
really matter.
-Dmitry
--
Dmitry Samersoff
Java Hotspot development team, SPB04
checks are eliminated.
Thanks!
and
RSVP
John Zavgren
john.zavg...@oracle.com
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
. Also major refactoring or formatting in a bug fix is a
royal pain for reviewers.
-Alan
--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com
--
Dmitry Samersoff
, because the run time checks
are eliminated.
Thanks!
and
RSVP
John Zavgren
john.zavg...@oracle.com
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
/solaris, I only did jtreg tests for Linux 32 and 64
build. The jtreg tests I ran are restricted to package java/net.
Please let me know if you need me to do more tests or on more platforms
(such as Solaris).
Best regards,
Frank
--
Dmitry Samersoff
Java Hotspot development team, SPB04
changes are simply
changing the definitions so that platforms like AIX will use the same
implementation as Solaris, Mac, etc. There will be no behavior changes
from this. You're just asking general questions, right?
On 16/08/2012 12:25, Dmitry Samersoff wrote:
Chris,
Sorry for being later
/6972374/webrev.00/webrev/
Thanks,
-Chris.
--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...
On 2010-07-12 22:30, Alan Bateman wrote:
Dmitry Samersoff wrote:
Alan,
Thank you for the comments.
Fixed.
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/
-Dmitry
The copyright date on the new test says 2008 :-)
Copy-paste from a neighbor ;)
Fixed?
http://cr.openjdk.java.net
Chris,
Please review my changes.
see:
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/
-Dmitry
--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...
Changeset: 887e525597f8
Author:dsamersoff
Date: 2010-06-23 17:25 +0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/887e525597f8
6931566: NetworkInterface is not working when interface name is more than 15
characters long
Summary: Separate Linux and Solaris code, use lifreq
96 matches
Mail list logo
