On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Wed, 28 Oct 2020 17:07:04 GMT, Chris Hegarty wrote:
>> Igor Ignatyev has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - use UTC TZ for RFC3659_DATETIME_FORMAT
>> - run TestFtpTimeValue with different user.timezone
>
> Marked as
On Wed, 28 Oct 2020 15:25:06 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this small and trivial fix?
>>
>> `sun/net/ftp/imp/FtpClient::dateFormats` is an array of `SimpleDateFormat`
>> which are shared among all instances of `FtpClient`. the fact that
>>
On Wed, 28 Oct 2020 11:10:33 GMT, Daniel Fuchs wrote:
>> Igor Ignatyev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - remove \n from MDTM response before parsing
>> - added leading 0 to the test
>> - use DateTimeFormatter instead
of the uriDecoderTest method. I am not 100% sure on
how to achieve that with JMH though, but hopefully there's some
way to do that.
best regards,
-- daniel
On 27/08/2020 14:11, Rahul Yadav wrote:
Hello,
Request to have my fix reviewed for issue:
JDK-8245308: Replace ThreadLocalCoders decoder/encoder cache
Hello,
Request to have my fix reviewed for issue:
JDK-8245308: Replace ThreadLocalCoders decoder/encoder cache in
java.net.URI.
This fix updates java.net.URI, replaces the ThreadLocalCoders optimization.
The benchmark results indicate no impact, optimization can be
replaced.The results of
Hi Chris,
Thanks for the feedback, this improves the test, i have included your
feedback and updated webrev.
- rahul
On 18/08/2020 14:28, Chris Hegarty wrote:
Rahul,
On 18 Aug 2020, at 10:21, Rahul Yadav wrote:
...
Issue: https://bugs.openjdk.java.net/browse/JDK-8251715
webrev: http
is the one you expect.
best regards,
-- daniel
On 18/08/2020 10:21, Rahul Yadav wrote:
Hello,
Request to have my fix reviewed for issue:
JDK-8251715: Throw UncheckedIOException in place of InternalError
when HttpClient fails due to unavailability of underlying resources
required by SSLContext
Hello,
Request to have my fix reviewed for issue:
JDK-8251715: Throw UncheckedIOException in place of InternalError when
HttpClient fails due to unavailability of underlying resources required
by SSLContext.
This fix updates jdk.internal.net.http.HttpClientImpl to throw an
Hello,
Request to have my fix reviewed for issue:
JDK-8248006: Revisit exceptions thrown when creating an HttpClient
fails due to unavailability of underlying resources.
This fix updates jdk.internal.net.http.HttpClientImpl to throw an
UncheckedIOException instead of InternalError,
when
less in the context of WebSocket URIs
and MUST NOT be used on these URIs. As with any URI scheme, the
character "#", when not indicating the start of a fragment, MUST be
escaped as %23.
-Pavel
On 26 Jun 2020, at 13:03, Rahul Yadav wrote:
Hello,
Request to have my
Hello,
Request to have my fix reviewed for issue:
JDK-8245245 : WebSocket can loose the URL encoding of URI query parameters
The fix updates the jdk.internal.net.http.websocket.OpeningHandshake
to ensure that the URL is not reencoded/decoded and loose the original
encoding
Issue:
Hello,
Request to have my fix reviewed for issue:
JDK-8247675 : WebSocket can loose the URL encoding of URI query parameters
The fix updates the jdk.internal.net.http.websocket.OpeningHandshake
to ensure that the URL is not reencoded/decoded and loose the original
encoding
Issue:
Hello,
Request to have my fix reviewed for issue:
JDK-8247675 : Update DateFormatterTest Copyright
The fix updates the test DateFormatterTest, adds the missing
comma(,) to the copyright year.
Issue: https://bugs.openjdk.java.net/browse/JDK-8247675
webrev:
Hi Daniel,
I have updated the copyright notice.
On 15/06/2020 16:23, Daniel Fuchs wrote:
Hi Rahul,
Sorry I didn't catch that earlier, but your test has the
wrong copyright notice. We do not have the "Classpath"
exception in tests.
best regards,
-- daniel
On 15/06/2020 11:41, R
Hi Chris, Daniel
Thank you for the comments.
I have included the feedback and updated webrev.
http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
- rahul
On 15/06/2020 10:28, Daniel Fuchs wrote:
Hi Rahul,
On 15/06/2020 09:52, Chris Hegarty wrote:
On 12 Jun 2020, at 17:55, Rahul
Hi Alan,
Thank you for the feedback.
I have updated the webrev.
http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
- rahul
On 12/06/2020 16:57, Alan Bateman wrote:
On 12/06/2020 15:56, Rahul wrote:
Hello,
Request to have my fix reviewed for the issue:
JDK-8245307 : Update
17 matches
Mail list logo
