On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
The security/crypto parts look good to me.
-
Marked as reviewed by xuelei (
On Thu, 19 May 2022 09:31:07 GMT, Kevin Walls wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> Also, I fixed a couple of spelling mistakes.
>
> test/jdk/sun/security/tools/jarsigner/OldSig.java line 32:
>
>> 30: /*
>> 31: * Se
On Mon, 16 May 2022 21:08:48 GMT, Anthony Scarpino
wrote:
> There is too much grey area. It says the src buffer maybe modified, which one
> could interpret it cannot be a read-only, but that would still need
> clarification to explicitly say "no read only buffers". And other than these
> inte
On Sat, 14 May 2022 03:29:14 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this fix to allow a read-only 'src' buffer to be used
>> with SSLEngine.unwrap(). A temporary read-write buffer is created in the
>> SSLCipher operation when a read-only buffer is passed. If the 'src' is
On Wed, 11 May 2022 22:49:02 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLEngine.java line 677:
>>
>>> 675: * @see #unwrap(ByteBuffer, ByteBuffer[], int, int)
>>> 676: *
>>> 677: * @implNote The data in {@code src} may be modified during the
>
On Fri, 29 Apr 2022 03:58:57 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this fix to allow a read-only 'src' buffer to be used with
> SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher
> operation when a read-only buffer is passed. If the 'src' is read
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type of the variable, a cast is
On Mon, 7 Mar 2022 07:52:29 GMT, Xue-Lei Andrew Fan wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors ac
.net/browse/JDK-8282724
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
update copyright years
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7722/files
- new: https://git.openjdk.java.net/jdk/pull/7722
On Fri, 18 Mar 2022 21:08:56 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more test case udpate
>
> test/jdk/javax/net/ssl/SSLException/CheckSSLH
On Tue, 8 Mar 2022 08:02:16 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constr
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote:
>> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
>> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
>> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
>> performed hal
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote:
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.ne
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
correct test case issues and more
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openjdk.java.ne
On Tue, 8 Mar 2022 16:13:08 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add test for DTLS
>
> src/java.base/share/classes/sun/security/ssl/SSLConfigur
.net/browse/JDK-8282724
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
more test case udpate
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7722/files
- new: https://git.openjdk.java.net/jdk/pull/7722
.net/browse/JDK-8282724
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
update usage in test template
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7722/files
- new: https://git.openjdk.java.net/jdk/
On Mon, 7 Mar 2022 20:34:02 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> src/java.base/share/classes/sun/security/ssl/ECDHKeyExc
.net/browse/JDK-8282724
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
update more usage and add test cases
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7722/files
- new: https://git.openjdk.java.ne
On Mon, 7 Mar 2022 20:36:41 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> src/java.base/share/classes/sun/security/ssl/SSLSock
On Mon, 7 Mar 2022 20:24:08 GMT, Rajan Halade wrote:
> Update following for SSLPeerUnverifiedException -
>
> https://github.com/openjdk/jdk/blob/master/src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java#L439
Hm, I will check more usage out of the JSSE implementation c
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constr
On Mon, 7 Mar 2022 20:30:07 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> src/java.base/share/classes/sun/security/ssl/SSLTraffic
.net/browse/JDK-8282724
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
typo correction
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7722/files
- new: https://git.openjdk.java.net/jdk/pull/7722
Please review this small API enhancement to add the usual constructors taking a
cause to javax.net.ssl exceptions. The use of initCause in the JSSE
implementation code is updated to use the new constructors accordingly.
Please review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282724
--
On Fri, 4 Mar 2022 16:29:04 GMT, Sean Mullan wrote:
> Since this new API is also intended to be supported for DTLS, have you added
> implementation support for that, and if so have you added a test for it?
Yes, the DTLS implementation is included. I added a test case for DTLS.
-
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
add test for DTLS
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openjdk.java.net/jdk/pull/7252
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to SocketException and then update uses of initiCause on creating
> SocketException to instead pass the cause via the constructor.
>
> Please also review
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote:
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
> performed half-cl
On Mon, 28 Feb 2022 19:44:19 GMT, Jamil Nimeh wrote:
>> src/java.base/share/classes/sun/security/ssl/CompressionAlgorithm.java line
>> 49:
>>
>>> 47: }
>>> 48:
>>> 49: static CompressionAlgorithm nameOf(String name) {
>>
>> Shouldn't this be valueOf? We're not consistent in the metho
Hi,
Please review the implementation of RFC 8879, TLS Certificate Compression, in
JDK. The TLS Certificate Compression standard is an essential part for QUIC
connections and performance improvement for TLS connections. More details,
please refer to the [JEP](https://bugs.openjdk.java.net/brow
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
more spec update per CSR feedback
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openjdk.java.ne
On Wed, 16 Feb 2022 19:21:58 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.ope
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Add implSpec about existence of the new methods
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openj
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
spec re-wording
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openjdk.java.net/jdk/pull/7252
On Wed, 9 Feb 2022 21:38:22 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Spec update
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 74
On Wed, 9 Feb 2022 14:33:11 GMT, Sean Mullan wrote:
>> Basically, the suggestion captures the implementation behaviors correctly.
>> To make it more accuracy, if we want to use it, we may need to consider more
>> cases:
>> 1. _explicitly set by application_, with null, empty or 1+ schemes.
>>
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Spec update
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openjdk.java.net/jdk/pull/7252/files/830
On Tue, 8 Feb 2022 20:18:20 GMT, Sean Mullan wrote:
>>> Are you maybe saying that this method returns the value of the system
>>> properties if they are set?
>>
>> The return value of this method depends on the following specs:
>>
>> * If the {@link #setSignatureSchemes} method has not be
On Mon, 7 Feb 2022 22:56:45 GMT, Xue-Lei Andrew Fan wrote:
>> Sorry, you will have to bear with me as I am still not sure how it works - I
>> want to know who wins, the API or the properties, if both are set and I
>> can't find where it answers that above. Maybe I nee
On Mon, 7 Feb 2022 22:18:03 GMT, Sean Mullan wrote:
>> I think lines 714-816/723-725 describe the behavior already.
>>
>> I was hesitate to use "override", as the System Property values and the
>> default signature schemes are not actually overrode. The default signature
>> schemes are still
On Mon, 7 Feb 2022 19:59:32 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.jav
.net/browse/JDK-8281290
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Update class summary
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7252/files
- new: https://git.openjdk.java.net/jdk/pull/7252
On Mon, 7 Feb 2022 19:51:28 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java l
On Sat, 5 Feb 2022 20:29:50 GMT, Xue-Lei Andrew Fan wrote:
> In [JDK-8281289](https://bugs.openjdk.java.net/browse/JDK-8281289), the
> SSLParameters class was updated with the patch:
>
> - return Collections.unmodifiableList(new
> ArrayList<>(sniNames.values()));
&
On Sun, 6 Feb 2022 22:11:06 GMT, Claes Redestad wrote:
> This looks like an appropriate solution which avoids the minor compatibility
> risk introduced by the previous change - and you might even end up being more
> efficient both when setting and reading the names/matchers.
>
> (Since we're g
In [JDK-8281289](https://bugs.openjdk.java.net/browse/JDK-8281289), the
SSLParameters class was updated with the patch:
- return Collections.unmodifiableList(new
ArrayList<>(sniNames.values()));
+ return List.copyOf(sniNames.values());
However, there's a small compatibility risk with this chang
On Sat, 5 Feb 2022 13:22:25 GMT, Claes Redestad wrote:
> There's a small compatibility risk with this change, e.g.,
> `List.copyOf(...).contains(null)` will throw NPE while
> `Collections.unmodifiableList(...).contains(null)` won't.
>
> If we accept that compatibility risk (which should probab
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote:
> Please review this trivial code clean up, for a little bit better performance.
This pull request has now been integrated.
Changeset: 42e272e1
Author: Xue-Lei Andrew Fan
URL:
https://git.openjdk.java.net/jdk/com
Please review this trivial code clean up, for a little bit better performance.
-
Commit messages:
- 8281289: Improve with List.copyOf
Changes: https://git.openjdk.java.net/jdk/pull/7356/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7356&range=00
Issue: https://bugs.
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Fri, 4 Feb 2022 16:35:22 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More update for the sec and impl
>
> src/java.base/share/classes/javax/net/s
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Fri, 4 Feb 2022 16:34:14 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More update for the sec and impl
>
> src/java.base/share/classes/javax/net/s
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Thu, 3 Feb 2022 21:30:59 GMT, Sean Mullan wrote:
> > > On a related issue, have you given any thought as to what the behavior
> > > should be if a 3rd-party JSSE provider is not updated to support these
> > > new methods? I don't know of a good way to address that since the API is
> > > not
On Wed, 2 Feb 2022 22:13:07 GMT, Sean Mullan wrote:
> On a related issue, have you given any thought as to what the behavior should
> be if a 3rd-party JSSE provider is not updated to support these new methods?
> I don't know of a good way to address that since the API is not part of the
> pro
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote:
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.ne
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.ope
On Wed, 2 Feb 2022 14:45:21 GMT, Sean Mullan wrote:
> A few more comments on the API.
All good catches! Thank you very much. Updated the spec, CSR and impl.
-
PR: https://git.openjdk.java.net/jdk/pull/7252
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Mon, 31 Jan 2022 21:55:18 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rollback to use captialized S
>
> src/java.base/share/classes/javax/net/s
On Mon, 31 Jan 2022 21:26:46 GMT, Sean Mullan wrote:
>> As there is increasing number of SSL parameters, applications may just use
>> the constructor with no argument, and use the set methods individually.
>
> Ok. You should specify what the default value of the signature schemes
> parameter is
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Mon, 31 Jan 2022 15:37:38 GMT, Xue-Lei Andrew Fan wrote:
> In the JSSE specification, the reference to "Java Security Standard Algorithm
> Names" specification is documented as "Java Cryptography Architecture
> Standard Algorithm Name Documentation". As sh
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Mon, 31 Jan 2022 20:05:45 GMT, Sean Mullan wrote:
> > > Please capitalize "specification" (i.e. "Specification") to be consistent
> > > with other references in the javadoc. Looks good otherwise.
> >
> >
> > OK. Just curious, why we want to use capitalized "specification"? This word
> > "s
On Mon, 31 Jan 2022 16:39:34 GMT, Sean Mullan wrote:
> Please capitalize "specification" (i.e. "Specification") to be consistent
> with other references in the javadoc. Looks good otherwise.
OK. Just curious, why we want to use capitalized "specification"? This word
"specification" is not a
> In the JSSE specification, the reference to "Java Security Standard Algorithm
> Names" specification is documented as "Java Cryptography Architecture
> Standard Algorithm Name Documentation". As should be corrected.
Xue-Lei Andrew Fan has updated the pull r
> In the JSSE specification, the reference to "Java Security Standard Algorithm
> Names" specification is documented as "Java Cryptography Architecture
> Standard Algorithm Name Documentation". As should be corrected.
Xue-Lei Andrew Fan has updated the pull r
In the JSSE specification, the reference to "Java Security Standard Algorithm
Names" specification is documented as "Java Cryptography Architecture Standard
Algorithm Name Documentation". As should be corrected.
-
Commit messages:
- 8280949: Correct the references for the Java Sec
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Sun, 30 Jan 2022 03:08:22 GMT, Bernd wrote:
>> Yes, it does. Do you like to use a for-loop, without new object allocation?
>
> Yes, static helper
Thanks for confirm. Updated to use a static helper method.
-
PR: https://git.openjdk.java.net/jdk/pull/7252
On Sun, 30 Jan 2022 03:06:35 GMT, Bernd wrote:
>> Yes. Array copy is a concern of mine, too. Hopefully, the frozen array
>> feature could help address the array copy issues in the future.
>
> Hmm.. I guess the different packages make it really hard to have an internal
> optimized getter. What
On Sun, 30 Jan 2022 03:03:37 GMT, Bernd wrote:
>> If we want to reuse the result, we may have to cache something. It is not
>> good to me. The parsing of the signature scheme names actually depends on
>> the provider. So at this point, in the Java SE API specification, it is not
>> easy to
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Fri, 28 Jan 2022 01:05:22 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Enrich the APIs specification
>
> src/java.base/share/classes/sun/security/ssl/
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Fri, 28 Jan 2022 00:58:37 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.jav
On Fri, 28 Jan 2022 15:26:56 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.
On Fri, 28 Jan 2022 00:54:53 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java
On Fri, 28 Jan 2022 15:50:49 GMT, Jamil Nimeh wrote:
>> You should also define the interaction with the system properties (probably
>> as an @implNote). Does `getSignatureSchemes` ever return the value of the
>> system properties? Does the `setSignatureSchemes` API always override the
>> prope
On Fri, 28 Jan 2022 15:17:25 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the
On Thu, 27 Jan 2022 23:43:51 GMT, Jie Fu wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters
This update is to support signature schemes customization for individual (D)TLS
connection. Please review the CSR as well:
CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
-
Commit messages:
- 8280494: https://bugs.openjdk.
On Thu, 20 Jan 2022 07:12:42 GMT, Xue-Lei Andrew Fan wrote:
> In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the
> return statement says that "The array is ordered based on protocol
> preference, with protocols[0] being the most preferred.". Howe
On Thu, 20 Jan 2022 15:31:55 GMT, Daniel Fuchs wrote:
>> Hm, much better. Thanks!
>
>> The phrase "descending order" seems more appropriate for numerical values. I
>> think the previous wording was more clear, with a small change: "The array
>> is ordered based on protocol preference, with the
On Thu, 20 Jan 2022 14:16:43 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update per feedback
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
thod.
>
> The update is a minor correction so that the specification is not rely on the
> "protocols" variable.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Update per feedback
-
Changes:
In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the
return statement says that "The array is ordered based on protocol preference,
with protocols[0] being the most preferred.". However, there is no "protocols"
variable in this method.
The update is a minor correction so
On Fri, 27 Aug 2021 01:35:17 GMT, Bradford Wetmore wrote:
> Did a quick sweep of some minor non-standard javadoc issues. This silences
> 3rd party tooling warnings and fixes some linkage issues.
Looks good to me. Thank you for the clean up.
src/java.base/share/classes/javax/net/ssl/SNIHostNa
On Tue, 25 May 2021 04:36:53 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix in the code sample in javadoc
> comment of `javax.net.ssl.SSLEngine` class?
>
> I've run `make docs-image` locally and the generated javadoc after this
> change looks fine.
Marked as reviewe
On Thu, 4 Mar 2021 04:02:03 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Wed, 3 Mar 2021 17:56:02 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Wed, 3 Mar 2021 15:10:54 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
> if (s instanceof SSLSocketImpl) {
> ((S
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
>
1 - 100 of 108 matches
Mail list logo
