Re: @since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Chris Hegarty
, > > Could someone please review my fix for JDK-8237075 '@since tag missing from > DatagramSocket and MulticastSocket methods' ? > > This trivial fix adds in the missing @since tags for methods listed below. > These methods were originally added in JDK 1.2. > &g

Re: @since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Daniel Fuchs
On 14/01/2020 11:49, Patrick Concannon wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8237075 webrev: http://cr.openjdk.java.net/~pconcannon/8237075/webrevs/webrev.00/ Looks good to me as well. best regards, -- daniel

Re: @since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Alan Bateman
On 14/01/2020 11:49, Patrick Concannon wrote: Hi, Could someone please review my fix for JDK-8237075 '@since tag missing from DatagramSocket and MulticastSocket methods' ? This trivial fix adds in the missing @since tags for methods listed below. These methods were originally ad

@since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Patrick Concannon
Hi, Could someone please review my fix for JDK-8237075 '@since tag missing from DatagramSocket and MulticastSocket methods' ? This trivial fix adds in the missing @since tags for methods listed below. These methods were originally added in JDK 1.2. java/net/DatagramSocket: >