On Wed, 16 Jun 2021 10:42:56 GMT, Patrick Concannon <pconcan...@openjdk.org> wrote:
> Hi, > > Could someone please review my change to the test > `test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java`? > The test is missing `/othervm` from its @run jtreg test tag, which risks > polluting other tests that run in that VM. > > Currently, any test that runs without `/othervm` after this test would find > the `DatagramSocketImpl` factory created by this test, and therefore any call > made to new `DatagramSocket()` would return/use a `NetMulticastSocket` > instead of `DatagramSocketAdaptor`. This could make tests that create > `DatagramSocket`/`MulticastSocket` fail intermittently in unexplainable ways. > Adding in `/othervm` to the @run tag will avoid this problem. > > Kind regards, > Patrick This pull request has now been integrated. Changeset: 7d7bdbe1 Author: Patrick Concannon <pconcan...@openjdk.org> URL: https://git.openjdk.java.net/jdk17/commit/7d7bdbe135018f1452fa133b294575014e3e871b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag Reviewed-by: dfuchs ------------- PR: https://git.openjdk.java.net/jdk17/pull/75
