Re: Code Review 6987461: Handle leak when enabling java.net.useSystemProxies

2010-09-29 Thread Michael McMahon
Chris Hegarty wrote: Michael, There is a leak in the windows version of the default proxy selector implementation. If no proxy is enabled on the system, i.e. HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyEnable = 0, then the handle to the registry key is n

Code Review 6987461: Handle leak when enabling java.net.useSystemProxies

2010-09-29 Thread Chris Hegarty
Michael, There is a leak in the windows version of the default proxy selector implementation. If no proxy is enabled on the system, i.e. HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyEnable = 0, then the handle to the registry key is never released. Webr