Code Review 6994079: PlainSocketImpl should close the socket if it fails

2010-10-22 Thread Chris Hegarty
Alan, Michael, connect(SocketAddress,int) should close the underlying file descriptor if it fails for any reason. This is consistent with the other connect methods. A little other cleanup while there. http://cr.openjdk.java.net/~chegar/6994079/webrev.00/webrev/ -Chris.

Re: Code Review 6994079: PlainSocketImpl should close the socket if it fails

2010-10-22 Thread Alan Bateman
Chris Hegarty wrote: Alan, Michael, connect(SocketAddress,int) should close the underlying file descriptor if it fails for any reason. This is consistent with the other connect methods. A little other cleanup while there. http://cr.openjdk.java.net/~chegar/6994079/webrev.00/webrev/ -Chris.

Re: Code Review 6994079: PlainSocketImpl should close the socket if it fails

2010-10-22 Thread Chris Hegarty
Alan Bateman wrote: Chris Hegarty wrote: Alan, Michael, connect(SocketAddress,int) should close the underlying file descriptor if it fails for any reason. This is consistent with the other connect methods. A little other cleanup while there.