RE: Patch for adding SO_REUSEPORT socket option

2016-02-23 Thread Lu, Yingqi
han, Sandhya <sandhya.viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 11/02/2016 17:47, Lu, Yingqi wrote: > : >

Re: Patch for adding SO_REUSEPORT socket option

2016-02-23 Thread Alan Bateman
On 11/02/2016 17:47, Lu, Yingqi wrote: : Please let us know if everything is all right. Again, thank you very much for your help! I've pushed the changes to the jdk9/dev forest: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f92af283ab18 -Alan.

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Volker Simonis
in, thank you very much for your help! >>> >>> Thanks, >>> Lucy >>> >>> >>> -Original Message- >>> From: Alan Bateman [mailto:alan.bate...@oracle.com] >>> Sent: Wednesday, February 10, 2016 10:38 AM >>> To: Lu, Yi

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Seán Coffey
<kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; net-dev@openjdk.java.net Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan, Here is the most recent modification of the patch. The link is available here: http://cr.openjdk.java.net/~mcberg/jdk/643

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Alan Bateman
On 17/02/2016 11:43, Chris Hegarty wrote: I know this has gone through several rounds of review already. I do not want to stall progress, I am reasonably happy with the changes, but I have a few comments ( that can be addressed later, if needed ). - MulticastSocket.java: I would add a

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Chris Hegarty
Eric <eric.kaczma...@intel.com>; Viswanathan, Sandhya <sandhya.viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; net-dev@openjdk.java.net Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan, Here is

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Alan Bateman
On 17/02/2016 09:22, Volker Simonis wrote: Hi Alan, I'm just running a quick test build on AIX to see if everything is still working. I'll let you know once it completes (latest today evening). I've done the same and I think we need to drop the patches to the DatagramChannel multicast tests

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Volker Simonis
Hi Alan, I'm just running a quick test build on AIX to see if everything is still working. I'll let you know once it completes (latest today evening). Thanks, Volker On Tue, Feb 16, 2016 at 11:18 PM, Alan Bateman wrote: > > > On 16/02/2016 18:03, Lu, Yingqi wrote: >>

Re: Patch for adding SO_REUSEPORT socket option

2016-02-16 Thread Lu, Yingqi
Thank u very much, Alan! Sent from my iPhone > On Feb 16, 2016, at 2:18 PM, Alan Bateman wrote: > > > >> On 16/02/2016 18:03, Lu, Yingqi wrote: >> Hi Alan, >> >> I am wondering if you got chances to review the latest patch? Thank you! >> >> Thanks, >> Lucy > I'm

Re: Patch for adding SO_REUSEPORT socket option

2016-02-16 Thread Alan Bateman
On 16/02/2016 18:03, Lu, Yingqi wrote: Hi Alan, I am wondering if you got chances to review the latest patch? Thank you! Thanks, Lucy I'm happy with the latest patch and I will try to get it into JDK 9 soon for you. -Alan

RE: Patch for adding SO_REUSEPORT socket option

2016-02-16 Thread Lu, Yingqi
..@intel.com>; net-dev@openjdk.java.net Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan, Here is the most recent modification of the patch. The link is available here: http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.11/ Please let us know if everything is all right.

RE: Patch for adding SO_REUSEPORT socket option

2016-02-11 Thread Lu, Yingqi
viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 05/02/2016 17:27, Lu, Yingqi wrote: > Hi Alan, > >

Re: Patch for adding SO_REUSEPORT socket option

2016-02-10 Thread Alan Bateman
On 05/02/2016 17:27, Lu, Yingqi wrote: Hi Alan, Here is the new modification of the patch. The link is available here: http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.10/ In this version, we make supportedOptions() in AbstractPlainSocketImpl and AbstractPlainDatagramSocketImpl return an

RE: Patch for adding SO_REUSEPORT socket option

2016-02-05 Thread Lu, Yingqi
kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 28/01/2016 06:03, Lu, Yingqi wrote: > Hi Alan, > > Here is a new version of the patch: > http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.08/ > > In this version, based on your comment, w

Re: Patch for adding SO_REUSEPORT socket option

2016-01-29 Thread Alan Bateman
On 28/01/2016 06:03, Lu, Yingqi wrote: Hi Alan, Here is a new version of the patch: http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.08/ In this version, based on your comment, we have changed following items: 1. Remove the dependency of DatagramSocketImpl and MulticastSocket with

RE: Patch for adding SO_REUSEPORT socket option

2016-01-27 Thread Lu, Yingqi
et-dev@openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 14/01/2016 18:2

RE: Patch for adding SO_REUSEPORT socket option

2016-01-07 Thread Lu, Yingqi
he, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 05/01/2016 18:56, Lu, Yingqi wrote: > Hi Alan, > > Sorry for the confusion. Let me be more detailed on the issue. > > In pr

Re: Patch for adding SO_REUSEPORT socket option

2016-01-07 Thread Alan Bateman
On 07/01/2016 16:41, Lu, Yingqi wrote: Hi Alan, In AbstractPlainSocketImpl, I am using the existing/default initializer so that there is only 1 initializer. However, it does not execute. That is the issue I am seeing. Any suggestion on the issue? Are you 100% sure that your updated

Re: Patch for adding SO_REUSEPORT socket option

2016-01-06 Thread Alan Bateman
On 05/01/2016 18:56, Lu, Yingqi wrote: Hi Alan, Sorry for the confusion. Let me be more detailed on the issue. In previous version of the patch, I added an initializer in SocketImpl.java to load the libnet.so since the isReusePortAvailable and its native implementation were there. Then,

Re: Patch for adding SO_REUSEPORT socket option

2016-01-05 Thread Volker Simonis
Hi Lucy, I've just looked at the javadoc of MulticastSocket. It has this sentence: * When the socket is created the * {@link DatagramSocket#setReuseAddress(boolean)} method is * called to enable the SO_REUSEADDR socket option. but it doesn't mention SO_REUSEPORT. Could you please

Re: Patch for adding SO_REUSEPORT socket option

2016-01-05 Thread Alan Bateman
On 05/01/2016 04:32, Lu, Yingqi wrote: Hi Alan/Volker, I just found out that the code works by adding the same static block (net library loading) into SocketImpl.java although isReusePortAvailable() is being defined in its subclass AbstractPlainSocketIml.java. I use a print statement to

RE: Patch for adding SO_REUSEPORT socket option

2016-01-05 Thread Lu, Yingqi
at...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 05/01/2016 04:32, Lu, Yingqi wrote: > Hi Alan/Volker, &

Re: Patch for adding SO_REUSEPORT socket option

2016-01-05 Thread Alan Bateman
On 04/01/2016 19:24, Volker Simonis wrote: On Mon, Jan 4, 2016 at 8:02 PM, Lu, Yingqi wrote: : 2. Regarding to the code snippet in net_util_md.c, the reason I check for ENOPROTOOPT is to enable SO_REUSEPORT in the situation that the feature is supported but something

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Alan Bateman
On 04/01/2016 18:43, Volker Simonis wrote: : Alan, what do you mean by "unknown" platform? Currently, as far as I know, 0x0200 is used by AIX and MacOS X. Do you suggest to name these platforms explicitly and set it to 0 otherwise? Leaving the default at 0x0200 has the advantage that it would

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com>; Viswanathan, Sandhya <sandhya.viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket o

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Volker Simonis
Hi Lucy, Alan, I'm back from vacation so here we go :) On Fri, Jan 1, 2016 at 12:18 PM, Alan Bateman wrote: > > On 21/12/2015 17:53, Lu, Yingqi wrote: >> >> Hi All, >> >> Sorry for the late reply. Here is the link to the most recent reversion of >> the patch (version

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Volker Simonis
On Mon, Jan 4, 2016 at 8:24 PM, Alan Bateman wrote: > > > On 04/01/2016 18:43, Volker Simonis wrote: >> >> : >> Alan, what do you mean by "unknown" platform? Currently, as far as I >> know, 0x0200 is used by AIX and MacOS X. Do you suggest to name these >> platforms

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Volker Simonis
3 AM > To: Alan Bateman <alan.bate...@oracle.com> > Cc: Lu, Yingqi <yingqi...@intel.com>; Kaczmarek, Eric > <eric.kaczma...@intel.com>; Viswanathan, Sandhya > <sandhya.viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; > Aundhe, Shirish <sh

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On Mon, Jan 4, 2016 at 8:24 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 04/01/2016 18:43, Volker Sim

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
hor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: RE: Patch for adding SO_REUSEPORT socket option One more question, we tried to move the isReusePortAvailable() from SocketImpl.java to AbstractPlainSocketImpl.jav

RE: Patch for adding SO_REUSEPORT socket option

2016-01-01 Thread Lu, Yingqi
To: Lu, Yingqi <yingqi...@intel.com> Cc: Viswanathan, Sandhya <sandhya.viswanat...@intel.com>; net-dev@openjdk.java.net; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch

Re: Patch for adding SO_REUSEPORT socket option

2016-01-01 Thread Alan Bateman
On 21/12/2015 17:53, Lu, Yingqi wrote: Hi All, Sorry for the late reply. Here is the link to the most recent reversion of the patch (version #6). http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.06/ In this version, we have done following modifications based on the feedback we received.

RE: Patch for adding SO_REUSEPORT socket option

2015-12-21 Thread Lu, Yingqi
t;; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: RE: Patch for adding SO_REUSEPORT socket option Hi All, Here is an update on the progress. Based on the comments and feedback we received, we modified following items in the upcoming version

RE: Patch for adding SO_REUSEPORT socket option

2015-12-08 Thread Lu, Yingqi
<volker.simo...@gmail.com> Cc: Kaczmarek, Eric <eric.kaczma...@intel.com>; net-dev@openjdk.java.net; Kharbas, Kishor <kishor.khar...@intel.com>; Viswanathan, Sandhya <sandhya.viswanat...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com> Subject: Re: Patch for adding S

RE: Patch for adding SO_REUSEPORT socket option

2015-12-08 Thread Lu, Yingqi
.net; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: RE: Patch for adding SO_REUSEPORT socket option Thank you very much for your help, Alan! Thanks, Lucy -Original Message- From:

Re: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Alan Bateman
On 02/12/2015 17:08, Lu, Yingqi wrote: Hi All, A quick check here. Does anyone get a chance to try the most recent patch? Any feedback and comments? Thanks, Lucy I looked through the latest webrev (webrev.05) and it's looking quite good. I agree with Michael, we should decide whether

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
shor.khar...@intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 02/12/2015 17:08, Lu, Yingqi wrote: Hi All, A quick check here. Does anyone get a chance to try the most recent patch? Any feedback and comments? Thanks, Lucy

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
, Yingqi <yingqi...@intel.com>; Alan Bateman <alan.bate...@oracle.com> Cc: Kaczmarek, Eric <eric.kaczma...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option Yes, since the functionality

Re: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Michael McMahon
intel.com>; Kaczmarek, Eric <eric.kaczma...@intel.com> *Subject:* Re: Patch for adding SO_REUSEPORT socket option On 02/12/2015 17:08, Lu, Yingqi wrote: Hi All, A quick check here. Does anyone get a chance to try the most recent patch? Any feedback and comments? Thanks,

Re: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Michael McMahon
.com>; net-dev@openjdk.java.net; Kharbas, Kishor <kishor.khar...@intel.com> *Subject:* RE: Patch for adding SO_REUSEPORT socket option Here is an update. Changes are already completed locally. All the tests passed on an old Linux kernel 3.4.110 which does not have SO_REUSEPORT. Same test

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
Mahon <michael.x.mcma...@oracle.com>; Kaczmarek, Eric <eric.kaczma...@intel.com>; net-dev@openjdk.java.net; Kharbas, Kishor <kishor.khar...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On Mon, Dec 7, 2015 at 7:02 PM, Lu, Yingqi <yingqi...@intel.com&g

Re: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Alan Bateman
On 07/12/2015 18:59, Lu, Yingqi wrote: Oh, I got it now. You want SO_REUSEPORT to be disabled by default for both ServerSocketChannelImpl and SocketChannelImpl. I am actually OK either way. Alan/Michael, what is your take on this? If we all think "default off" is the correct/better way to

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
;; Kaczmarek, Eric <eric.kaczma...@intel.com>; net-dev@openjdk.java.net; Kharbas, Kishor <kishor.khar...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 07/12/2015 18:59, Lu, Yingqi wrote: > Oh, I got it now. You want SO_REUSEPORT to be disabled by default fo

Re: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Volker Simonis
> To: Lu, Yingqi <yingqi...@intel.com>; Alan Bateman <alan.bate...@oracle.com>; > Michael McMahon <michael.x.mcma...@oracle.com> > Cc: Kaczmarek, Eric <eric.kaczma...@intel.com>; net-dev@openjdk.java.net; > Kharbas, Kishor <kishor.khar...@intel.com> >

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
; > Thanks, > > Lucy > > > > From: Lu, Yingqi > Sent: Monday, November 30, 2015 11:25 PM > To: Lu, Yingqi <yingqi...@intel.com>; Volker Simonis > <volker.simo...@gmail.com> > > > Cc: Kaczmarek, Eric <eric.kaczma...@intel.com>; > net-dev@o

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
Bateman' <alan.bate...@oracle.com>; Volker Simonis <volker.simo...@gmail.com> Cc: Michael McMahon <michael.x.mcma...@oracle.com>; Kaczmarek, Eric <eric.kaczma...@intel.com>; net-dev@openjdk.java.net; Kharbas, Kishor <kishor.khar...@intel.com> Subject: RE: Patch for add

RE: Patch for adding SO_REUSEPORT socket option

2015-11-30 Thread Lu, Yingqi
gt;>; net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>; Kaczmarek, Eric <eric.kaczma...@intel.com<mailto:eric.kaczma...@intel.com>> Subject: RE: Patch for adding SO_REUSEPORT socket option Yes, it should work! I already located the issues. Good catch! I will submit an

RE: Patch for adding SO_REUSEPORT socket option

2015-11-25 Thread Lu, Yingqi
el.x.mcma...@oracle.com>; Alan Bateman <alan.bate...@oracle.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: RE: Patch for adding SO_REUSEPORT socket option Yes, it should work! I already located the issu

Re: Patch for adding SO_REUSEPORT socket option

2015-11-25 Thread Volker Simonis
et-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Michael > McMahon > Sent: Monday, November 23, 2015 2:54 AM > To: Volker Simonis <volker.simo...@gmail.com>; Alan Bateman > <alan.bate...@oracle.com> > Cc: Kharbas, Kishor <kishor.khar...@intel.com>; net

RE: Patch for adding SO_REUSEPORT socket option

2015-11-25 Thread Lu, Yingqi
el.x.mcma...@oracle.com>; Alan Bateman <alan.bate...@oracle.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net; Kaczmarek, Eric <eric.kaczma...@intel.com> Subject: Re: Patch for adding SO_REUSEPORT socket option Yes, I indeed tested on an old kernel - bu

RE: Patch for adding SO_REUSEPORT socket option

2015-11-24 Thread Lu, Yingqi
k.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option I agree we should enable the option on all platforms. We can add the code to do that and run the tests. On the existing use of SO_REUSEPORT on AIX and Mac it appears that is set to emulate expected behavior on other platforms

RE: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Lu, Yingqi
ael.x.mcma...@oracle.com] Sent: Monday, November 23, 2015 3:42 AM To: Volker Simonis <volker.simo...@gmail.com>; Alan Bateman <alan.bate...@oracle.com> Cc: Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net; Lu, Yingqi <yingqi...@intel.com> Subject: Re: Patch for

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Alan Bateman
On 23/11/2015 04:12, Lu, Yingqi wrote: Hi Alan, One more question please JI want to make sure I understand correctly on your following suggestion. In order to use supportedOptions method to test SO_REUSEPORT, I will need to first write a native function to check if SO_REUSEPORT is

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Michael McMahon
I agree we should enable the option on all platforms. We can add the code to do that and run the tests. On the existing use of SO_REUSEPORT on AIX and Mac it appears that is set to emulate expected behavior on other platforms when SO_REUSEADDR is set for datagram sockets. The expectation is that

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Michael McMahon
How about the following for the apidoc in j.n.StandardSocketOptions? We can then reference this text from everywhere else rather than repeating it. (just noticed Lucy was not included in the last few mails) - Michael /** * Re-use port. * * The value of this socket option

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Volker Simonis
Hi Lucy, in general I support the addition of SO_REUSEPORT to the set of standard socket options. However for me the problem is not that this new option is not supported on all platforms, but instead that it has such different semantics on different platforms. If you look at the code, you'll see

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Volker Simonis
On Mon, Nov 23, 2015 at 11:54 AM, Michael McMahon wrote: > I agree we should enable the option on all platforms. > We can add the code to do that and run the tests. > > On the existing use of SO_REUSEPORT on AIX and Mac > it appears that is set to emulate expected

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Michael McMahon
> Subject: Re: Patch for adding SO_REUSEPORT socket option How about the following for the apidoc in j.n.StandardSocketOptions? We can then reference this text from everywhere else rather than repeating it. (just noticed Lucy was not included in the last few mails) - Micha

Re: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Volker Simonis
rted. >> >> Thank you, >> Lucy >> >> -Original Message- >> From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] >> Sent: Monday, November 23, 2015 3:42 AM >> To: Volker Simonis <volker.simo...@gmail.com>; Alan Bateman >>

RE: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Lu, Yingqi
, November 22, 2015 12:25 AM To: Lu, Yingqi <yingqi...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anythi

RE: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Lu, Yingqi
yingqi...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more tha

RE: Patch for adding SO_REUSEPORT socket option

2015-11-20 Thread Lu, Yingqi
<alan.bate...@oracle.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net; Michael McMahon <michael.x.mcma...@oracle.com>; core-libs-dev <core-libs-dev-boun...@openjdk.java.net> Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan and M

RE: Patch for adding SO_REUSEPORT socket option

2015-11-20 Thread Lu, Yingqi
shor.khar...@intel.com>; net-dev@openjdk.java.net; Michael McMahon <michael.x.mcma...@oracle.com> Subject: Re: Patch for adding SO_REUSEPORT socket option On 20/11/2015 20:59, Lu, Yingqi wrote: Hello All, We added Version 3 of the patch here. http://cr.openjdk.java.net/~mcberg/jdk/64320

Re: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Alan Bateman
On 16/11/2015 18:49, Kharbas, Kishor wrote: P.S. Based on Alan Baleman's comment on JBS, we are in meanwhile working on adding this option to 'java.net.ExtendedSocketOption'. My comment in the bug was just to bring up the question as to whether this should be a standard or JDK-specific

RE: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Lu, Yingqi
; Kharbas, Kishor; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/ I presume that a review

Re: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Michael McMahon
gqi Lu (Lucy) *From:*net-dev [mailto:net-dev-boun...@openjdk.java.net] *On Behalf Of *Michael McMahon *Sent:* Thursday, November 19, 2015 6:11 AM *To:* Kharbas, Kishor; net-dev@openjdk.java.net *Subject:* Re: Patch for adding SO_REUSEPORT socket option Hi Kishor Did you mean to include the

Re: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Michael McMahon
Thanks Mark. I'll take a look at the patch then - Michael On 19/11/15 14:52, Mark Sheppard wrote: there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031

Re: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Mark Sheppard
there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/ I presume

Patch for adding SO_REUSEPORT socket option

2015-11-16 Thread Kharbas, Kishor
Hello all, I request the community to review a patch for adding SO_REUSEPORT support. There is already an existing JBS opened at https://bugs.openjdk.java.net/browse/JDK-6432031 Details : SO_REUSEPORT removes 1:1 assignment between listen socket and IP:PORT pair and enable multiple sockets