RE: Ping: RFR (M): 8167481: cleanup of headers and includes for native libnet

Thanks, Chris. I pushed it... > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Mittwoch, 26. Oktober 2016 15:39 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net > Subject: Re: Ping: RFR (M): 8167481: cleanup of headers

Re: Ping: RFR (M): 8167481: cleanup of headers and includes for native libnet

> On 20 Oct 2016, at 16:30, Langer, Christoph wrote: > > Chris, > > I created a new version that addresses your points: > http://cr.openjdk.java.net/~clanger/webrevs/8167481.1/ Looks good to me. > I reordered the headers according to your suggestions ( 1) system, 2)

RE: Ping: RFR (M): 8167481: cleanup of headers and includes for native libnet

Chris, I created a new version that addresses your points: http://cr.openjdk.java.net/~clanger/webrevs/8167481.1/ I reordered the headers according to your suggestions ( 1) system, 2) platform specific includes, 3) JNI includes, and finally, 4) generated headers ), added the @Native and

Re: Ping: RFR (M): 8167481: cleanup of headers and includes for native libnet

Christoph, > On 17 Oct 2016, at 09:40, Langer, Christoph wrote: > … > Hi, > > as I already mentioned, here is another proposal for cleanup in libnet: > https://bugs.openjdk.java.net/browse/JDK-8167481 > http://cr.openjdk.java.net/~clanger/webrevs/8167481.0/ Overall,

Ping: RFR (M): 8167481: cleanup of headers and includes for native libnet

Hi, is there any comments/reviews for my cleanup work here? The changeset was added to our local OpenJDK build and test infrastructure several days ago and it does not show issues... Thanks Christoph From: Langer, Christoph Sent: Mittwoch, 12. Oktober 2016 14:17 To: net-dev@openjdk.java.net