On Fri, 4 Dec 2020 11:22:34 GMT, Kartik Ohri
wrote:
> @pconcannon, If everything is in order, can you please approve the changes on
> Github. I'll then issue the integrate command. Thanks.
Hi @amCap1712, you will have to /integrate first, and then afterwards I will
sponsor
-
PR:
On Wed, 2 Dec 2020 16:35:24 GMT, Daniel Fuchs wrote:
>> Kartik Ohri has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Align -> and remove trailing whitespace
>
> Marked as reviewed by dfuchs (Reviewer).
@pconcannon, If everything is in or
On Wed, 2 Dec 2020 16:34:17 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has up
On Wed, 2 Dec 2020 16:28:44 GMT, Kartik Ohri
wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1HeaderParser.java
>> line 119:
>>
>>> 117: while (canContinueParsing(input)) {
>>> 118: switch (state) {
>>> 119: case INITIAL ->
On Wed, 2 Dec 2020 16:15:13 GMT, Chris Hegarty wrote:
>> Kartik Ohri has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> I think that the actual source changes
On Wed, 2 Dec 2020 09:42:09 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has re
On Wed, 2 Dec 2020 16:23:11 GMT, Daniel Fuchs wrote:
>> Kartik Ohri has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/java.net.http/share/classes/jdk/inte
On Wed, 2 Dec 2020 16:26:43 GMT, Patrick Concannon
wrote:
>> Kartik Ohri has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/java.net.http/share/classes/jd
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has updated the pull request incrementally with one additional
commit
On Wed, 2 Dec 2020 09:42:09 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has re
On Wed, 2 Dec 2020 09:42:09 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has re
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has refreshed the contents of this pull request, and previous
commits
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has updated the pull request incrementally with one additional
commit
On Tue, 1 Dec 2020 01:51:35 GMT, John Jiang wrote:
> Do we have clear guideline or requirement for using this new lang feature?
> We know there are a lot of old switch-case blocks in the existing codes,
> including source codes and test codes.
@johnshajiang I don't think we have any global guide
On Mon, 30 Nov 2020 13:04:11 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has r
On Sat, 21 Nov 2020 11:45:42 GMT, Kartik Ohri
wrote:
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Just a question.
Do we hav
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has refreshed the contents of this pull request, and previous
commits
Hi!
Kindly review this patch to replace switch statements with switch expressions
(where it makes sense) in the http client modules. The rationale is to improve
readability of the code.
Regards,
Kartik
-
Commit messages:
- Use switch expressions in jdk.internal.net.http and java.ne
18 matches
Mail list logo
