Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-04 Thread Felix Yang
Hi Chris,   pushed with build tags. Thanks, Felix On 2017/9/4 17:42, Chris Hegarty wrote: On 4 Sep 2017, at 06:29, Felix Yang > wrote: Hi Mark and Roger,     thanks for the comments. Adjusted the test to just simply print information

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-04 Thread Chris Hegarty
> On 4 Sep 2017, at 06:29, Felix Yang wrote: > > Hi Mark and Roger, > > thanks for the comments. Adjusted the test to just simply print > information for all network interfaces on failing. > > Webrev: > >

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-03 Thread Felix Yang
Hi Mark and Roger,     thanks for the comments. Adjusted the test to just simply print information for all network interfaces on failing. Webrev: http://cr.openjdk.java.net/~xiaofeya/8134989/webrev.01/ Thanks, Felix On 2017/9/1 22:44, Mark Sheppard wrote: Hi   it's  worth noting that

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-01 Thread Mark Sheppard
Hi   it's  worth noting that there is diagnostic output for each of the test scenarios, and that for a failure scenario the details of the network interface associated with the failure is displayed. a typical failure scenario for this test is where a host has multiple network interfaces

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-01 Thread Roger Riggs
Hi Felix, Looks ok; though could be simpler to just print all the addresses of all NIs. findIntefacesWithDupAddress could use streams more effectively (if its worth the time to rewrite). The inetAddresses() method on NetworkInterface produces a stream of InetAddress which could be

RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

2017-09-01 Thread Felix Yang
Hi there,     please review a test patch for isolating a network configuration issue, which led to TestInterfaces failing from time to time. Bug:     https://bugs.openjdk.java.net/browse/JDK-8134989 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8134989/webrev.00/ Thanks, Felix