Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 09:39, Vyom Tewari wrote: > i need sponsor for this fix. I pushed this: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/49781476b709 , with a few additional modifications: 1) Unrelated; added missing @since tags to impl supportedOptions ( these

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 09:39, Vyom Tewari wrote: > i need sponsor for this fix. I will sponsor this for you. -Chris. > Vyom > > On 3/3/2016 2:37 PM, Alan Bateman wrote: >> >> >> On 03/03/2016 09:03, Chris Hegarty wrote: >>> On 3 Mar 2016, at 05:36, Vyom Tewari

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Vyom Tewari
i need sponsor for this fix. Vyom On 3/3/2016 2:37 PM, Alan Bateman wrote: On 03/03/2016 09:03, Chris Hegarty wrote: On 3 Mar 2016, at 05:36, Vyom Tewari wrote: please find the updated webrev http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Alan Bateman
On 03/03/2016 09:03, Chris Hegarty wrote: On 3 Mar 2016, at 05:36, Vyom Tewari wrote: please find the updated webrev http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ Looks fine. Looks okay

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 05:36, Vyom Tewari wrote: > please find the updated webrev > > http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ > Looks fine. -Chris. > Thanks, > Vyom > > > On 3/2/2016 2:36

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-02 Thread Vyom Tewari
please find the updated webrev http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ Thanks, Vyom On 3/2/2016 2:36 PM, Chris Hegarty wrote: On 2 Mar 2016, at 08:19, Alan Bateman wrote: On

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-02 Thread Chris Hegarty
> On 2 Mar 2016, at 08:19, Alan Bateman wrote: > > > > On 02/03/2016 06:47, vyom wrote: >> Hi Chris/Alan, >> >> Thanks for review, please find the updated >> webrev(http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.1/index.html >>

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-02 Thread Alan Bateman
On 02/03/2016 06:47, vyom wrote: Hi Chris/Alan, Thanks for review, please find the updated webrev(http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.1/index.html ). This looks much better. I see the test is

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-01 Thread vyom
Hi Chris/Alan, Thanks for review, please find the updated webrev(http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.1/index.html ). Thanks, Vyom On Tuesday 01 March 2016 03:20 PM, Chris Hegarty wrote: On 1 Mar

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-01 Thread Chris Hegarty
On 1 Mar 2016, at 09:45, Alan Bateman wrote: > On 01/03/2016 09:27, vyom wrote: >> Hi All, >> >> Please review my code changes for the below issue. >> >> Bug: JDK-8148609 : supportedOptions() methods return a mutable set >> Webrev:

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-01 Thread Alan Bateman
On 01/03/2016 09:27, vyom wrote: Hi All, Please review my code changes for the below issue. Bug: JDK-8148609 : supportedOptions() methods return a mutable set Webrev: http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.0/

RFR 8148609: supportedOptions() methods return a mutable set

2016-03-01 Thread vyom
Hi All, Please review my code changes for the below issue. Bug: JDK-8148609 : supportedOptions() methods return a mutable set Webrev: http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.0/ Thanks, Vyom