Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-21 Thread Chris Hegarty
On 21/03/16 08:11, vyom wrote: Hi, i modified the existing ftp server that we are using it for our testing so that when server starts it will return a response which contains some empty new lines. This change will ensures that readServerResponse() throws the "IndexOutOfBoundsException" which we

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-21 Thread vyom
Hi, i modified the existing ftp server that we are using it for our testing so that when server starts it will return a response which contains some empty new lines. This change will ensures that readServerResponse() throws the "IndexOutOfBoundsException" which we are catching. As existing t

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-19 Thread Chris Hegarty
On 17 Mar 2016, at 06:57, vyom wrote: > > Hi Chris, > > thanks for review, please find the updated webrev. I updated the existing > test case to cover this issue. > > http://cr.openjdk.java.net/~vtewari/8151586/webrev0.1/index.html >

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-19 Thread vyom
On Thursday 17 March 2016 02:17 PM, Chris Hegarty wrote: On 17 Mar 2016, at 06:57, vyom wrote: Hi Chris, thanks for review, please find the updated webrev. I updated the existing test case to cover this issue. http://cr.openjdk.java.net/~vtewari/8151586/webrev0.1/index.html

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-18 Thread vyom
Hi Chris, thanks for review, please find the updated webrev. I updated the existing test case to cover this issue. http://cr.openjdk.java.net/~vtewari/8151586/webrev0.1/index.html Thanks, Vyom On Tuesday 15 March 2016 05:

Re: RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-15 Thread Chris Hegarty
Vyom, On 15/03/16 09:51, vyom wrote: Hi, Please review the below fix. Bug: JDK-8151586 : Wrong exception catch for FTPClient in JDK-8055032 Webrev :http://cr.openjdk.java.net/~rgoel/~vyom/8151586/webrev0.0/ The source change lo

RFR 8151586: Wrong exception catch for FTPClient in JDK-8055032

2016-03-15 Thread vyom
Hi, Please review the below fix. Bug: JDK-8151586 : Wrong exception catch for FTPClient in JDK-8055032 Webrev :http://cr.openjdk.java.net/~rgoel/~vyom/8151586/webrev0.0/ Thanks, Vyom