Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-21 Thread Brad Wetmore
I notice you've changed a lot of http server tests to run in othervm mode. Do they have to run in othervm mode? Just thinking about the overall test time. In samevm mode all the http server tests that use SSL fail with java.lang.NoClassDefFoundError: "Could not initialize class javax.crypto.Jc

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-21 Thread Chris Hegarty
On 07/21/10 12:58, Alan Bateman wrote: Chris Hegarty wrote: : Thinking about this. If the test ever fails, even with a rerun, can we be certain that it is a bug or just a slow machine? I guess removing the test may be the best course of action. If you agree, 'hg remove' or something else? I

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-21 Thread Alan Bateman
Chris Hegarty wrote: : Thinking about this. If the test ever fails, even with a rerun, can we be certain that it is a bug or just a slow machine? I guess removing the test may be the best course of action. If you agree, 'hg remove' or something else? I haven't seen this test fail but clearly

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-21 Thread Chris Hegarty
On 07/19/10 15:11, Alan Bateman wrote: Chris Hegarty wrote: : In samevm mode all the http server tests that use SSL fail with java.lang.NoClassDefFoundError: "Could not initialize class javax.crypto.JceSecurityManager". This is really weird. I exchanged mail with Jon Gibbons about this, but we n

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-19 Thread Alan Bateman
Chris Hegarty wrote: : In samevm mode all the http server tests that use SSL fail with java.lang.NoClassDefFoundError: "Could not initialize class javax.crypto.JceSecurityManager". This is really weird. I exchanged mail with Jon Gibbons about this, but we never got to the bottom of it. At th

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-19 Thread Chris Hegarty
On 07/15/10 18:11, Alan Bateman wrote: Chris Hegarty wrote: Alan, Can you please review these various updates to the jdk net regression tests. Mainly closing of sockets, samevm issues, dial back of tests, etc.. Webrev: http://cr.openjdk.java.net/~chegar/6969395/webrev.00/webrev/ Thanks. -Chri

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-15 Thread Alan Bateman
Chris Hegarty wrote: Alan, Can you please review these various updates to the jdk net regression tests. Mainly closing of sockets, samevm issues, dial back of tests, etc.. Webrev: http://cr.openjdk.java.net/~chegar/6969395/webrev.00/webrev/ Thanks. -Chris. Good work! A few comments: Sh