Re: RFR[8234812]: 'Add micros for DatagramChannel send/receive'

2020-02-14 Thread Patrick Concannon
Hi, Thanks for the feedback Chris and Alan. I've added an boolean parameter to the benchmark to allow for the use of a direct ByteBuffer -- true for direct, false for heap. In interest of keeping the run time of the benchmark down, I've only included a 'true' value. However, 'false' can be

Re: RFR[8234812]: 'Add micros for DatagramChannel send/receive'

2020-02-14 Thread Alan Bateman
On 13/02/2020 16:53, Chris Hegarty wrote: : Did you intentionally use heap byte buffers, or should the test use direct buffers? That is a good discussion point as there is a matrix of heap vs. direct, blocking vs. non-blocking, scatter/gather, ... that could be added to create more

Re: RFR[8234812]: 'Add micros for DatagramChannel send/receive'

2020-02-13 Thread Chris Hegarty
> On 13 Feb 2020, at 14:27, Patrick Concannon > wrote: > > Hi, > > > Could someone please review my webrev for JDK-8234812 'Add micros for > DatagramChannel send/receive' ? > > This test adds some benchmarks for the DatagramChannel's send, receive, read > and write methods. > > > bug: