Re: icmp and raw sockets on linux

2020-12-11 Thread Daniel Fuchs
I Jamie, Yes - you will need at least one Reviewer and then a sponsor. From the brief glance I had at your patch it looked reasonable. Let me have a deeper look. best regards, -- daniel On 09/12/2020 18:35, Jamie Le Tual wrote: I'm wondering what the process is for the pull request I submitted

Re: icmp and raw sockets on linux

2020-12-09 Thread Jamie Le Tual
I'm wondering what the process is for the pull request I submitted, I guess I need a reviewer or a sponsor? On Tue, 1 Dec 2020 at 14:08, Jamie Le Tual wrote: > Hi Alan, > I received an email this morning saying my OCA had been processed, but > that it would perhaps take a couple of hours before

Re: icmp and raw sockets on linux

2020-12-01 Thread Jamie Le Tual
Hi Alan, I received an email this morning saying my OCA had been processed, but that it would perhaps take a couple of hours before a bot picks it up and I show up on the OCA signatories page (no idea where that page is though). I have also updated the patch in my pull request to cover ipv6 as wel

Re: icmp and raw sockets on linux

2020-11-29 Thread Alan Bateman
On 29/11/2020 14:54, Jamie Le Tual wrote: Although I've only just sent in the pdf form for an ora, I've already submitted a pull request, https://github.com/openjdk/jdk/pull/1502

Re: icmp and raw sockets on linux

2020-11-29 Thread Jamie Le Tual
Although I've only just sent in the pdf form for an ora, I've already submitted a pull request, https://github.com/openjdk/jdk/pull/1502 wherein an attempt is first made to use an IPPROTO_ICMP socket before falling back on RAW_SOCK and finally tcp echo. I suppose now I have to wait until I am able

Re: icmp and raw sockets on linux

2020-11-28 Thread Alan Bateman
On 28/11/2020 02:42, Jamie Le Tual wrote: : It all seems to check out (at least on my machine,) the icmp packets look good in wireshark, so the first thing I'm wondering is what the catch must be, because this seems like a simple solution and I'm wondering why it was never done like this. T

Re: icmp and raw sockets on linux

2020-11-27 Thread Bernd Eckenfels
Hello, Good find Jamie, The change for this is from 2010, so it should be in all recent Linux kernels (not sure if this means no fallback is needed - maybe keep the tcp fallback) https://lwn.net/Articles/420800/ BTW the article also,mentions there is a way to do this in MacOS also. Gruss Bern