Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-22 Thread Alan Bateman
On 22/12/2011 16:14, Michael McMahon wrote: Final webrev hopefully: http://cr.openjdk.java.net/~michaelm/7120875/webrev.5/ I'm happy with this. -Alan

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-22 Thread Michael McMahon
On 22/12/11 13:46, Michael McMahon wrote: On 22/12/11 13:34, Alan Bateman wrote: On 22/12/2011 11:46, Michael McMahon wrote: I've updated this to localize the changes to NetworkInterface (and the new class DefaultInterface). So, there's no change to the socket impl java code The new native c

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-22 Thread Michael McMahon
On 22/12/11 13:34, Alan Bateman wrote: On 22/12/2011 11:46, Michael McMahon wrote: I've updated this to localize the changes to NetworkInterface (and the new class DefaultInterface). So, there's no change to the socket impl java code The new native code implementation is in net_util_md.c also

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-22 Thread Alan Bateman
On 22/12/2011 11:46, Michael McMahon wrote: I've updated this to localize the changes to NetworkInterface (and the new class DefaultInterface). So, there's no change to the socket impl java code The new native code implementation is in net_util_md.c also, but called from Plain*SocketImpl.c :

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-22 Thread Michael McMahon
On 19/12/11 14:11, Alan Bateman wrote: On 16/12/2011 10:36, Michael McMahon wrote: Updated webrev after Alan's comments. http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ This is better but would be nice if we could avoid special casing MacOSX in java.net.MulticastSocket. Given that we ma

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-19 Thread Alan Bateman
On 16/12/2011 10:36, Michael McMahon wrote: Updated webrev after Alan's comments. http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ This is better but would be nice if we could avoid special casing MacOSX in java.net.MulticastSocket. Given that we may have to choose the default interface

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-16 Thread Kurchi Hazra
The changes in the following files are not required I guess - perhaps they are my bad test/java/net/DatagramSocket/B6411513.java ||test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java - Kurchi* * On 12/16/2011 2:36 AM, Michael McMahon wrote: Updated webrev after

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-16 Thread Michael McMahon
Updated webrev after Alan's comments. http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ Thanks, Michael. On 14/12/11 19:39, Michael McMahon wrote: Hi, This webrev fixes a bunch of test script issues in networking and core-libs. In most if not all cases, the change relates to recognising

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Alan Bateman
On 14/12/2011 20:57, Michael McMahon wrote: A check for "os.version" in the shared version of MulticastSocket would work. There's only a couple of lines of additional code required. But, then we don't want os specific code in the shared tree either. Don't know if you have other suggestions? T

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Alan Bateman
On 14/12/2011 20:27, Kurchi Hazra wrote: : - I did not look through individual tests, but only the ones that failed - I assumed that they will throw some error message if the platform is not recognized. That's mostly true for the shell tests but there are many pure java tests that look at o

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Michael McMahon
On 14/12/11 19:54, Alan Bateman wrote: On 14/12/2011 19:39, Michael McMahon wrote: Hi, This webrev fixes a bunch of test script issues in networking and core-libs. In most if not all cases, the change relates to recognising the OS that the test is running on. It also fixes an IPv6 issue, wh

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Kurchi Hazra
On 12/14/2011 12:15 PM, Alan Bateman wrote: On 14/12/2011 20:05, Kurchi Hazra wrote: On 12/14/2011 11:54 AM, Alan Bateman wrote: : In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would make sense to combine SunOS, Linux and Darin into the one case. More generally then I guess

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Alan Bateman
On 14/12/2011 20:05, Kurchi Hazra wrote: On 12/14/2011 11:54 AM, Alan Bateman wrote: : In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would make sense to combine SunOS, Linux and Darin into the one case. More generally then I guess most of these tests could be changed so that

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Kurchi Hazra
On 12/14/2011 11:54 AM, Alan Bateman wrote: On 14/12/2011 19:39, Michael McMahon wrote: Hi, This webrev fixes a bunch of test script issues in networking and core-libs. In most if not all cases, the change relates to recognising the OS that the test is running on. It also fixes an IPv6 is

Re: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Alan Bateman
On 14/12/2011 19:39, Michael McMahon wrote: Hi, This webrev fixes a bunch of test script issues in networking and core-libs. In most if not all cases, the change relates to recognising the OS that the test is running on. It also fixes an IPv6 issue, which requires Macos versions of a couple

Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

2011-12-14 Thread Michael McMahon
Hi, This webrev fixes a bunch of test script issues in networking and core-libs. In most if not all cases, the change relates to recognising the OS that the test is running on. It also fixes an IPv6 issue, which requires Macos versions of a couple of java.net classes. These are the new files