Re: Small improvements to Inet6 implementation (unix)

2010-09-01 Thread Michael McMahon
Martin Buchholz wrote: Hi net maintainers, I'd like you to do a code review. I got frustrated with incomplete information from exceptions thrown from java.net , so I hacked up some fixes for them. This is the result. generify; remove compiler warnings, typos, casts; return

hg: jdk7/tl/langtools: 6979683: inconsistent interaction of reference cast with box/unbox conversions leaves out a useful case

2010-09-01 Thread john . r . rose
Changeset: d3ead6731a91 Author:jrose Date: 2010-09-01 03:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d3ead6731a91 6979683: inconsistent interaction of reference cast with box/unbox conversions leaves out a useful case Summary: Allow casts which narrow and then un

hg: jdk7/tl/jdk: 6981145: (se) Eliminate JNI*Critical when creating pipes and other cleanups

2010-09-01 Thread martinrb
Changeset: bb8f48e1e042 Author:martin Date: 2010-09-01 09:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bb8f48e1e042 6981145: (se) Eliminate JNI*Critical when creating pipes and other cleanups Summary: Avoid *Critical; fix compile warnings; improve readability Reviewed-by

Re: Small improvements to Inet6 implementation (unix)

2010-09-01 Thread Martin Buchholz
On Wed, Sep 1, 2010 at 06:27, Michael McMahon wrote: > Martin Buchholz wrote: > >> Hi net maintainers, >> >> I'd like you to do a code review. >> >> I got frustrated with incomplete information from exceptions thrown from >> java.net , so I hacked up some fixes for them. This is

Re: Small improvements to Inet6 implementation (unix)

2010-09-01 Thread Martin Buchholz
I just noticed that I get gai_strerror_ptr dynamically, but then called gai_strerror directly and incorrectly. Here's a more robust way to get the error string: const char *error_string = (gai_strerror_ptr == NULL) ? NULL : (*gai_strerror_ptr)(gai_error); if (error_string == NULL)

hg: jdk7/tl/jdk: 6977887: (doc) Java 6 API missing info about encoding parameter in storeToXML method

2010-09-01 Thread mandy . chung
Changeset: b200263f1b68 Author:mchung Date: 2010-09-01 17:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b200263f1b68 6977887: (doc) Java 6 API missing info about encoding parameter in storeToXML method Reviewed-by: sherman ! src/share/classes/java/util/Properties.java

hg: jdk7/tl/jaxp: 6981408: Upgrade jaxp to 1.4.4

2010-09-01 Thread kelly . ohair
Changeset: a3fe5892cd26 Author:ohair Date: 2010-09-01 13:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/a3fe5892cd26 6981408: Upgrade jaxp to 1.4.4 Reviewed-by: darcy Contributed-by: Joe Wang ! jaxp.properties