Re: Code Review 7024560: InetAddress.getLocalHost().getHostName() returns localhost for hostnames of length HOST_NAME_MAX

2011-03-10 Thread Chris Hegarty
On 03/ 9/11 05:07 PM, Alan Bateman wrote: Chris Hegarty wrote: : I tested on a few different Linux machines and instrumented the error handling code, it is definitely failing with ENAMETOOLONG. Okay, must be a glibc thing. The changes you have look okay to me but would be nice to ensure that

Re: Code Review 7024560: InetAddress.getLocalHost().getHostName() returns localhost for hostnames of length HOST_NAME_MAX

2011-03-10 Thread Alan Bateman
Chris Hegarty wrote: > > > On 03/ 9/11 05:07 PM, Alan Bateman wrote: >> Chris Hegarty wrote: >>> : >>> I tested on a few different Linux machines and instrumented the error >>> handling code, it is definitely failing with ENAMETOOLONG. >> Okay, must be a glibc thing. The changes you have look okay

Re: URI ignores invalid ipv6 address while parsing authority

2011-03-10 Thread Chris Hegarty
Alan, Michael, Could you please take a look at the webrev below. On 03/ 8/11 12:15 PM, Chris Hegarty wrote: > On 03/ 8/11 09:21 AM, Jing LV wrote: >> >> (I am not sure but it seems the mail was not sent successfully - sorry if >> you receive it twice!) >> Thanks Chris. I see the bug 7023363

Re: URLConnection.guessContentTypeFromStream() does not support UTF8 and UTF32 with BOM

2011-03-10 Thread Chris Hegarty
Charles, Alan, I filed CR 7026346: " URLConnection.guessContentTypeFromStream does not support UTF-8 and UTF-32 xml streams with BOM", for this issue. I also creating a webrev from your patch, with the following changes: * Moved the UTF-32BE before the UTF-32LE, as per the comment * filled

Re: URLConnection.guessContentTypeFromStream() does not support UTF8 and UTF32 with BOM

2011-03-10 Thread Alan Bateman
Chris Hegarty wrote: Charles, Alan, I filed CR 7026346: " URLConnection.guessContentTypeFromStream does not support UTF-8 and UTF-32 xml streams with BOM", for this issue. I also creating a webrev from your patch, with the following changes: * Moved the UTF-32BE before the UTF-32LE, as per

hg: jdk7/tl/jdk: 7016078: javax.net.ssl.SSLException: Received fatal alert: internal_error starting JDK 7 b126

2011-03-10 Thread vincent . x . ryan
Changeset: 7766633ec80f Author:vinnie Date: 2011-03-10 18:21 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7766633ec80f 7016078: javax.net.ssl.SSLException: Received fatal alert: internal_error starting JDK 7 b126 Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs

hg: jdk7/tl/langtools: 6776656: Incorrect number in 'generated' help-doc.html

2011-03-10 Thread bhavesh . patel
Changeset: da10d62990a7 Author:bpatel Date: 2011-03-10 14:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/da10d62990a7 6776656: Incorrect number in 'generated' help-doc.html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.p

Re: SocketPermission's implies() interesting behavior

2011-03-10 Thread Charles Lee
On 03/11/2011 02:33 AM, Neil Richards wrote: On 10 March 2011 03:18, Charles Lee wrote: With a quick search in the SocketPermission using "cname =" as search word, cname always seems to be lower cases. But hostname does not. It may need some rework on the patch. I think using String.regionMatc