Re: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos

2011-11-25 Thread Michael McMahon
Looks good to me. - Michael. On 23/11/11 17:57, Chris Hegarty wrote: This CR is simply to cleanup the style of the java.net.HttpCookie source code. This has bugged me for a while! 1) Remove extraneous newlines 2) Use consistent javadoc comment style 3) Fix typos in public specification, sp

Re: A behavior difference about reachable test for address zero

2011-11-25 Thread Chris Hegarty
On 25/11/2011 05:58, Sean Chou wrote: Yes. ping 0.0.0.0 on linux works; while windows report not reachable. Right, so InetAddress.isReachable is reporting the same result as the native ping command. Is this an issue for you guys? -Chris. On Tue, Nov 22, 2011 at 9:22 PM, Alan Bateman mailto

hg: jdk8/tl/jdk: 7115150: java.net.HttpCookie code cleanup, style, formatting, typos

2011-11-25 Thread chris . hegarty
Changeset: 387190e1f782 Author:chegar Date: 2011-11-25 10:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/387190e1f782 7115150: java.net.HttpCookie code cleanup, style, formatting, typos Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java

Re: A behavior difference about reachable test for address zero

2011-11-25 Thread Sean Chou
No. Once before a time there was a testcase about it, so I just make sure it's a testcase problem. Thanks anyway. On Fri, Nov 25, 2011 at 7:28 PM, Chris Hegarty wrote: > On 25/11/2011 05:58, Sean Chou wrote: > >> Yes. ping 0.0.0.0 on linux works; while windows report not reachable. >> > > Right,

hg: jdk8/tl/jdk: 7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor

2011-11-25 Thread chris . hegarty
Changeset: e5ecbf555679 Author:chegar Date: 2011-11-25 13:46 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5ecbf555679 7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor Reviewed-by: chegar, alanb Contributed-by: sa...@taobao.com ! src/share/classes/su