hg: jdk8/tl/jdk: 7129029: (fs) Unix file system provider should be buildable on platforms that don't support O_NOFOLLOW

2012-01-13 Thread alan . bateman
Changeset: 7e593aa6ad41 Author:littlee Date: 2012-01-13 13:20 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e593aa6ad41 7129029: (fs) Unix file system provider should be buildable on platforms that don't support O_NOFOLLOW Reviewed-by: alanb ! src/solaris/classes/sun/nio/

Re: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X

2012-01-13 Thread Kurchi Hazra
Resending this request - Kurchi On 1/11/2012 11:15 AM, Kurchi Hazra wrote: Hi, For IPv6 on solaris or linux, setting the traffic class option is handled in the java layer. The native calls to set socket option simply returns a success and get socket option returns a dummy -1 value. test/

Re: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X

2012-01-13 Thread Alan Bateman
Bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127771 Webrev : http://cr.openjdk.java.net/~khazra/7127771/webrev.00/ What you have is fine although you could combine with the Solaris code? Should the __ALLBSD_SOURCE XXX be removed while you are there? -Alan

Re: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X

2012-01-13 Thread Kurchi Hazra
How does this look: http://cr.openjdk.java.net/~khazra/7127771/webrev.01/ - Kurchi On 1/13/2012 12:14 PM, Alan Bateman wrote: Bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127771 Webrev : http://cr.openjdk.java.net/~khazra/7127771/webrev.00/ What you have is fine although you c