The source code changes look fine to me.
I'm not sure why you enabled a security manager in the test. I don't
think that it needs one. You can remove the explicit setting of the SM
from the test code, remove the policy file, and the also the jtreg
policy tag. Otherwise looks fine.
-Chris.
I looked at the source code changes, and it looks good.
Thanks,
- Kurchi
On 3/13/2013 7:42 AM, Chris Hegarty wrote:
The source code changes look fine to me.
I'm not sure why you enabled a security manager in the test. I don't
think that it needs one. You can remove the explicit setting of
Thank you Rob.
-Chris
On 13 Mar 2013, at 18:02, Rob McKenna rob.mcke...@oracle.com wrote:
Thanks Kurchi, Chris, Dmitry,
I'm planning to fix that testcase and to make the logger final before
integration.
-Rob
On 13/03/13 17:55, Kurchi Hazra wrote:
I looked at the source code
Changeset: 94335b6ffb32
Author:jgish
Date: 2013-03-13 11:24 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94335b6ffb32
8002070: Remove the stack search for a resource bundle for Logger to use
Summary: The fragile, vulnerable, stack crawling has been eliminated from
Changeset: f5c85c0a9af0
Author:robm
Date: 2013-03-14 00:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c85c0a9af0
8009650: HttpClient available() check throws SocketException when connection
has been closed
Reviewed-by: chegar, khazra, dsamersoff
Contributed-by:
Changeset: 19a59a13b3ef
Author:dholmes
Date: 2013-03-14 01:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/19a59a13b3ef
8009428: Revert changes to $ substitution performed as part of nashorn
integration
Reviewed-by: alanb, erikj
! common/makefiles/MakeBase.gmk
Changeset: 41289b4a1819
Author:dholmes
Date: 2013-03-14 01:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41289b4a1819
8009429: Miscellaneous profiles cleanup
8009428: Revert changes to $ substitution performed as part of nashorn
integration
Reviewed-by: alanb, erikj
!
Changeset: 82dc1e827c2a
Author:dholmes
Date: 2013-03-14 01:45 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82dc1e827c2a
8009429: Miscellaneous profiles cleanup
Reviewed-by: jjg, alanb
! src/share/classes/com/sun/tools/javac/sym/Profiles.java