Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-06 Thread Chris Hegarty
On 06/06/2013 01:06 AM, Kurchi Hazra wrote: Hi, Please review this change to fix 7051862. For ACCEPT_ORIGINAL_SERVER, shouldAccept() throws a NullPointerException for null arguments. Out of the many options to fix this, I think the best way is to return false if either of the arguments is null

hg: jdk8/tl/jdk: 8015470: Remove redundant calls of toString() on String objects

2013-06-06 Thread david . holmes
Changeset: 571e5f452640 Author:dholmes Date: 2013-06-06 05:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/571e5f452640 8015470: Remove redundant calls of toString() on String objects Reviewed-by: dholmes, alanb Contributed-by: Otavio Goncalves otarioj...@java.net !

hg: jdk8/tl/jdk: 8000450: Restrict access to com/sun/corba/se/impl package

2013-06-06 Thread sean . coffey
Changeset: c4480e0d9f53 Author:coffeys Date: 2013-06-06 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4480e0d9f53 8000450: Restrict access to com/sun/corba/se/impl package Reviewed-by: alanb, chegar, lancea ! src/share/lib/security/java.security-linux !

hg: jdk8/tl/langtools: 6 new changesets

2013-06-06 Thread maurizio . cimadamore
Changeset: 6e30a513c945 Author:mcimadamore Date: 2013-06-06 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e30a513c945 6360970: javac erroneously accept ambiguous field reference Summary: clash between ambiguous fields in superinterface and unambiguous field in

hg: jdk8/tl/jdk: 8009579: Xpathexception does not honor initcause()

2013-06-06 Thread dmitry . degrave
Changeset: e6d2c605930c Author:dmeetry Date: 2013-06-06 20:43 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6d2c605930c 8009579: Xpathexception does not honor initcause() Reviewed-by: alanb, dholmes, joehw Contributed-by: aleksej.efi...@oracle.com +

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-06 Thread Kurchi Hazra
On 6/6/2013 2:07 AM, Chris Hegarty wrote: On 06/06/2013 01:06 AM, Kurchi Hazra wrote: Hi, Please review this change to fix 7051862. For ACCEPT_ORIGINAL_SERVER, shouldAccept() throws a NullPointerException for null arguments. Out of the many options to fix this, I think the best way is to

hg: jdk8/tl/jaxp: 8013434: Xalan and Xerces internal ObjectFactory need rework

2013-06-06 Thread daniel . fuchs
Changeset: e93beba07830 Author:dfuchs Date: 2013-06-06 20:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e93beba07830 8013434: Xalan and Xerces internal ObjectFactory need rework Summary: With this changeset, DTMManager and XSLTCDTMManager will always use their own

hg: jdk8/tl/jdk: 2 new changesets

2013-06-06 Thread mike . duigou
Changeset: 69d566198fe4 Author:henryjen Date: 2013-06-05 15:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69d566198fe4 8015522: CharSequence.codePoints can be faster Reviewed-by: martin, psandoz, alanb Contributed-by: henry@oracle.com !

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-06 Thread Kurchi Hazra
How does this look: http://cr.openjdk.java.net/~khazra/7051862/webrev.01/ - Kurchi On 6/6/2013 11:15 AM, Kurchi Hazra wrote: On 6/6/2013 2:07 AM, Chris Hegarty wrote: On 06/06/2013 01:06 AM, Kurchi Hazra wrote: Hi, Please review this change to fix 7051862. For ACCEPT_ORIGINAL_SERVER,

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-06 Thread Chris Hegarty
On 6 Jun 2013, at 21:58, Kurchi Hazra kurchi.subhra.ha...@oracle.com wrote: How does this look: http://cr.openjdk.java.net/~khazra/7051862/webrev.01/ Looks fine to me. -Chris. - Kurchi On 6/6/2013 11:15 AM, Kurchi Hazra wrote: On 6/6/2013 2:07 AM, Chris Hegarty wrote: On

hg: jdk8/tl/jdk: 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

2013-06-06 Thread mandy . chung
Changeset: 986793409b2b Author:bpb Date: 2013-06-05 21:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/986793409b2b 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal Summary: Performance improvements for double/float - String and decimal/hex

hg: jdk8/tl/jdk: 8016063: getFinalAttributes should use FindClose

2013-06-06 Thread rob . mckenna
Changeset: d28f802ce914 Author:robm Date: 2013-06-06 22:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d28f802ce914 8016063: getFinalAttributes should use FindClose Reviewed-by: alanb ! src/windows/native/java/io/WinNTFileSystem_md.c

hg: jdk8/tl/jdk: 8016117: New sun.misc.FDBigInteger class as part of 7032154

2013-06-06 Thread mandy . chung
Changeset: f5f54e493a64 Author:bpb Date: 2013-06-06 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5f54e493a64 8016117: New sun.misc.FDBigInteger class as part of 7032154 Reviewed-by: martin, iris Contributed-by: Sergey Kuksenko sergey.kukse...@oracle.com, Brian