Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-01 Thread Bernd Eckenfels
Am Thu, 1 Sep 2016 23:08:15 +0300 schrieb Dmitry Samersoff : > gettimeofday is affected by system time changes, so running ntpd can > cause unpredictable behavior of this code. Also it's rather expensive > syscall. At least on Linux It is actually not a syscall at

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-01 Thread Langer, Christoph
+1 From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Mark Sheppard Sent: Donnerstag, 1. September 2016 19:51 To: Vyom Tewari ; net-dev@openjdk.java.net Subject: Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set Hi Vyom,

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-01 Thread Dmitry Samersoff
Vyom, Did you consider to use select() to calculate timeout instead of gettimeofday ? gettimeofday is affected by system time changes, so running ntpd can cause unpredictable behavior of this code. Also it's rather expensive syscall. -Dmitry On 2016-09-01 19:03, Vyom Tewari wrote: > please

Re: Review request JDK-8165180: Provide a shared secret to access non-public ServerSocket constructor

2016-09-01 Thread Alan Bateman
On 31/08/2016 21:48, Mandy Chung wrote: This patch introduces JavaNetSocketAccess to allow access to non-public ServerSocket constructor that is accessed by some other area as a clean up. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165180/webrev.00/ This looks okay to me.

Re: java.net.http orElse(null) in SSLDelegate and other nits

2016-09-01 Thread Chris Hegarty
Thanks for reporting these issues Bernd, > On 27 Aug 2016, at 17:25, Bernd Eckenfels wrote: > > Hello, > > trying to understand the new jdk9 hierachy I noticed that this code: > >

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-01 Thread Vyom Tewari
please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.1/index.html ). I incorporated the review comments. Thanks, Vyom On Tuesday 30 August 2016 04:11 PM, Mark Sheppard wrote: Hi perhaps

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-01 Thread Vyom Tewari
hi Dimitry, thanks for review, I did consider to use a monotonically increasing clock like "clock_gettime" but existing nearby code("NET_Timeout") uses "gettimeofday" so i choose to be consistent with the existing code. Thanks, Vyom On Friday 02 September 2016 01:38 AM, Dmitry