RE: [PATCH] 8035653: jdk8u152-b01 windows crash on DatagramSocket.getLocalAddress

2017-04-19 Thread Langer, Christoph
Hi Alex, I've just quickly checked this and it seems worthwile to me to downport 8035653 to JDK8. As the patch will probably not apply cleanly to JDK8 after unshuffling [1] , you will need to create a new public review and post it on this mailing list. Some JDK8 reviewer needs to review it and

RFR (10) : 8177457 and 8177452

2017-04-19 Thread Michael McMahon
Could I get the following JDK 10 reviews please. They are minor doc cleanups, that do not involve spec changes https://bugs.openjdk.java.net/browse/JDK-8177457 https://bugs.openjdk.java.net/browse/JDK-8177452 8177457 Syntax errors in URLConnection class documentation 8177452 Syntax errors in C

Re: RFR (10) : 8177457 and 8177452

2017-04-19 Thread Chris Hegarty
> On 19 Apr 2017, at 17:36, Michael McMahon > wrote: > > Could I get the following JDK 10 reviews please. > They are minor doc cleanups, that do not involve spec changes > > https://bugs.openjdk.java.net/browse/JDK-8177457 > https://bugs.openjdk.java.net/browse/JDK-8177452 > > 8177457 Syntax

Re: RFR (10) : 8177457 and 8177452

2017-04-19 Thread Roger Riggs
Hi Michael, Looks fine. But they are applicable to JDK 9 and as doc changes are acceptable. Why JDK 10? Roger On 4/19/2017 12:36 PM, Michael McMahon wrote: Could I get the following JDK 10 reviews please. They are minor doc cleanups, that do not involve spec changes https://bugs.openjdk.jav